Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add captureCheckIn() #1573

Merged
merged 13 commits into from
Jul 31, 2023
Merged

Add captureCheckIn() #1573

merged 13 commits into from
Jul 31, 2023

Conversation

will2877
Copy link
Contributor

This PR comes from the discussion related to this topic in #getsentry/sentry-symfony#719 and adds the upsert MonitorConfig to the HubInterface as well as the descending Hub and HubAdapter.

This way we don't need to add the environment and release details multiple times but will take this information from the Options as provided by the ClientInterface in the Hub.

cleptric
cleptric requested changes Jul 26, 2023
View reviewed changes
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🚀

Please also add captureCheckIn to functions.php.

I'll give this a quick spin and review this further later this week.

src/State/HubInterface.php Outdated Show resolved Hide resolved
cleptric
cleptric reviewed Jul 27, 2023
View reviewed changes
src/functions.php Outdated Show resolved Hide resolved
ste93cry
ste93cry requested changes Jul 29, 2023
View reviewed changes
src/State/Hub.php Outdated Show resolved Hide resolved
src/State/Hub.php Outdated Show resolved Hide resolved
tests/FunctionsTest.php Outdated Show resolved Hide resolved
tests/FunctionsTest.php Outdated Show resolved Hide resolved
@cleptric cleptric self-assigned this Jul 31, 2023
@cleptric cleptric marked this pull request as draft July 31, 2023 13:53
@cleptric cleptric requested a review from stayallive July 31, 2023 14:12
@cleptric cleptric marked this pull request as ready for review July 31, 2023 14:12
@cleptric
Copy link
Member

@will2877 Thanks again for opening this PR. I pushed some changes to your branch and we'll get this merged soon 🙂

@cleptric cleptric merged commit 153a988 into getsentry:master Jul 31, 2023
29 checks passed
@will2877 will2877 mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ste93cry ste93cry ste93cry approved these changes

@cleptric cleptric cleptric approved these changes

@stayallive stayallive Awaiting requested review from stayallive

Assignees

@cleptric cleptric

Labels
Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@will2877 @cleptric @ste93cry