Remove metrics plumbing and deprecate/no-op public API #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleptric
approved these changes
Oct 31, 2024
| @@ -132,10 +132,6 @@ public function getDisabledUntil(EventType $eventType): int | |||
| $category = self::DATA_CATEGORY_ERROR; | |||
| } | |||
|
|
|||
| if ($eventType === EventType::metrics()) { | |||
| $category = self::DATA_CATEGORY_METRIC_BUCKET; | |||
There was a problem hiding this comment.
We can also remove the definition.
cleptric
added a commit
to getsentry/sentry-laravel
that referenced
this pull request
Nov 5, 2024
Part of getsentry/sentry-php#1786, though we can get this one merged any time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics beta has ended unfortunately so we can stop sending data because it will no longer be accepted so to reduce overhead I've removed as much plumbing as possible while keeping not breaking the public API. We can remove the skeleton next major.
The deprecation message I placed everywhere might be improved a bit.
Read more: https://sentry.zendesk.com/hc/en-us/articles/26369339769883-Metrics-Beta-Ended-on-October-7th