Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Fix add_query_source with modules outside of project root #3313

Merged
merged 5 commits into from
Oct 1, 2024

Commits on Sep 5, 2024

  1. ref(tracing): Move should_be_included logic into function

    The change is required for unit testing the logic.
    rominf committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e3bb1c0 View commit details
    Browse the repository at this point in the history
  2. fix(tracing): Fix add_query_source with modules outside of project …

    …root
    
    Fix: getsentry#3312
    
    Previously, when packages added in `in_app_include` were installed
    to a location outside of the project root directory, span from
    those packages were not extended with OTel compatible source code
    information. Cases include running Python from virtualenv created
    outside of the project root directory or Python packages installed into
    the system using package managers. This resulted in an inconsistency:
    spans from the same project would be different, depending on the
    deployment method.
    
    In this change, the logic was slightly changed to avoid these
    discrepancies and conform to the requirements, described in the PR with
    better setting of in-app in stack frames:
    getsentry#1894 (comment).
    rominf committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c6ce9c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    b7c382f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c41170 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Configuration menu
    Copy the full SHA
    7751e5d View commit details
    Browse the repository at this point in the history