Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(aiohttp): Make DEFUALT_FAILED_REQUEST_STATUS_CODES private #3558

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

szokeasaurusrex
Copy link
Member

There is no reason this constant should be part of the public API. Since no release has included this constant yet, making this constant private does not require a major version bump.

There is no reason this constant should be part of the public API. Since no release has included this constant yet, making this constant private does not require a major version bump.
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (09c6f2a) to head (d64c360).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3558      +/-   ##
==========================================
- Coverage   84.31%   84.30%   -0.01%     
==========================================
  Files         133      133              
  Lines       13890    13890              
  Branches     2930     2930              
==========================================
- Hits        11711    11710       -1     
  Misses       1442     1442              
- Partials      737      738       +1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/aiohttp.py 85.11% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly this would've been fine to leave as is -- I don't see any reason for anyone to use this outside of the SDK and it's not part of the advertised API. But I'm fine either way.

@szokeasaurusrex szokeasaurusrex merged commit 3995132 into master Sep 25, 2024
125 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/privatize-constant branch September 25, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants