-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce rust_tracing integration #3717
feat: introduce rust_tracing integration #3717
Conversation
dc6660e
to
82d3239
Compare
❌ 3 Tests Failed:
View the full list of 3 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
CI seems hung, not sure if that is my fault somehow or what |
407d294
to
4d72832
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very cool. I added some minor requests.
ac1302a
to
413c197
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some rework, this integration is now ready to be merged!
this PR introduces a new integration that allows traces to descend into code in Rust native extensions by hooking into Rust's popular
tracing
framework. it relies on the Rust native extension usingpyo3-python-tracing-subscriber
, a crate i recently published under Sentry, to expose a way for the Python SDK to hook intotracing
.in this screenshot, the transaction was started in Python but the rest of the span tree reflects the structure and performance of a naive fibonacci generator in Rust.
i have a
sentry-docs
branch with new docs for the integration pretty much ready to go. just want to get this merged and then add a working example topyo3-python-tracing-subscriber
to link to first