Make sentry-sdk[pure-eval] installable with pip==24.0 #3757
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue with
pip==24.0
where extras with an underscore in the name can't be installed, so e.g.pip install sentry-sdk[pure_eval]
will claim there is nopure_eval
extra.The issue is fixed in
pip>=24.1
. Some folks are stuck using older versions though. We can fix it for them by renaming the extra topure-eval
instead, which makespip install sentry-sdk[pure-eval]
work correctly in 24.0 too.(The underscore version
sentry-sdk[pure_eval]
will continue to work after this change. Tested with pip and uv.)Closes #3754