Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Enable Django cache_spans by default #3994

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BYK
Copy link
Member

@BYK BYK commented Jan 24, 2025

This reverts commit 955108e (#3791) and simply enables cache_spans by default..

This reverts commit 955108e (#3791) and simply enables `cache_spans` by default..
@BYK BYK requested a review from antonpirker January 24, 2025 21:55
Copy link

codecov bot commented Jan 24, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
22079 3 22076 5708
View the top 3 failed tests by shortest run time
tests.integrations.aiohttp.test_aiohttp test_crumb_capture
Stack Traces | 0.002s run time
file .../integrations/aiohttp/test_aiohttp.py, line 476
  @pytest.mark.asyncio
  async def test_crumb_capture(
      sentry_init, aiohttp_raw_server, aiohttp_client, loop, capture_events
  ):
      def before_breadcrumb(crumb, hint):
E       fixture 'loop' not found
>       available fixtures: DictionaryContaining, ObjectDescribedBy, StringContaining, _capture_internal_warnings, _session_event_loop, aiohttp_client, aiohttp_client_cls, aiohttp_raw_server, aiohttp_server, benchmark, cache, capfd, capfdbinary, caplog, capsys, capsysbinary, capture_envelopes, capture_events, capture_events_forksafe, capture_exceptions, capture_record_lost_event_calls, clean_scopes, cov, doctest_namespace, event_loop, event_loop_policy, httpserver, httpsserver, internal_exceptions, maybe_monkeypatched_threading, monkeypatch, no_cover, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, render_span_tree, reset_integrations, sentry_init, smtpserver, suppress_deprecation_warnings, teardown_profiling, .../integrations/aiohttp/test_aiohttp.py::<event_loop>, tests/integrations/aiohttp::<event_loop>, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, uninstall_integration, unused_tcp_port, unused_tcp_port_factory, unused_udp_port, unused_udp_port_factory, validate_event_schema
>       use 'pytest --fixtures [testpath]' for help on them.

.../integrations/aiohttp/test_aiohttp.py:476
tests.integrations.aiohttp.test_aiohttp test_crumb_capture
Stack Traces | 0.002s run time
file .../integrations/aiohttp/test_aiohttp.py, line 476
  @pytest.mark.asyncio
  async def test_crumb_capture(
      sentry_init, aiohttp_raw_server, aiohttp_client, loop, capture_events
  ):
      def before_breadcrumb(crumb, hint):
E       fixture 'loop' not found
>       available fixtures: DictionaryContaining, ObjectDescribedBy, StringContaining, _capture_internal_warnings, _session_event_loop, aiohttp_client, aiohttp_client_cls, aiohttp_raw_server, aiohttp_server, benchmark, cache, capfd, capfdbinary, caplog, capsys, capsysbinary, capture_envelopes, capture_events, capture_events_forksafe, capture_exceptions, capture_record_lost_event_calls, clean_scopes, cov, doctest_namespace, event_loop, event_loop_policy, httpserver, httpsserver, internal_exceptions, maybe_monkeypatched_threading, monkeypatch, no_cover, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, render_span_tree, reset_integrations, sentry_init, smtpserver, suppress_deprecation_warnings, teardown_profiling, .../integrations/aiohttp/test_aiohttp.py::<event_loop>, tests/integrations/aiohttp::<event_loop>, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, uninstall_integration, unused_tcp_port, unused_tcp_port_factory, unused_udp_port, unused_udp_port_factory, validate_event_schema
>       use 'pytest --fixtures [testpath]' for help on them.

.../integrations/aiohttp/test_aiohttp.py:476
tests.test_basics test_staticmethod_tracing
Stack Traces | 0.164s run time
tests/test_basics.py:925: in test_staticmethod_tracing
    assert fake_start_child.call_count == 1
E   AssertionError: assert 4 == 1
E    +  where 4 = <MagicMock name='mock.start_child' id='140013195602864'>.call_count

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant