Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(2.5) test: Adds snapshot tests #4379

Open
wants to merge 8 commits into
base: antonis/3859-newCaptureFeedbackAPI-Form
Choose a base branch
from
Open

(2.5) test: Adds snapshot tests #4379

wants to merge 8 commits into from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Dec 16, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Adds snapshot tests for the defaults, custom texts and custom styles

💡 Motivation and Context

See #4328 (comment)

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis mentioned this pull request Dec 16, 2024
Open
10 tasks
@antonis antonis changed the title (2.4) test: Adds snapshot tests (2.5) test: Adds snapshot tests Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 407.80 ms 407.63 ms -0.18 ms
Size 17.74 MiB 20.10 MiB 2.37 MiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI-Form

Startup times

Revision Plain With Sentry Diff
03c9048 500.96 ms 486.65 ms -14.31 ms
561640f 461.96 ms 458.11 ms -3.85 ms
a3ba405 438.16 ms 435.78 ms -2.38 ms
50c70c0 496.82 ms 526.02 ms 29.20 ms
cadf235 462.20 ms 463.34 ms 1.14 ms
f4a5053 478.22 ms 458.35 ms -19.87 ms
1dd8d17 399.65 ms 393.81 ms -5.84 ms
a06f6ba 424.02 ms 415.82 ms -8.20 ms
0781f75 452.32 ms 457.22 ms 4.91 ms
e0624b6 447.67 ms 441.08 ms -6.59 ms

App size

Revision Plain With Sentry Diff
03c9048 17.74 MiB 20.10 MiB 2.37 MiB
561640f 17.74 MiB 20.09 MiB 2.35 MiB
a3ba405 17.74 MiB 20.09 MiB 2.35 MiB
50c70c0 17.74 MiB 20.10 MiB 2.36 MiB
cadf235 17.74 MiB 20.09 MiB 2.35 MiB
f4a5053 17.74 MiB 20.10 MiB 2.36 MiB
1dd8d17 17.74 MiB 20.10 MiB 2.36 MiB
a06f6ba 17.74 MiB 20.09 MiB 2.35 MiB
0781f75 17.74 MiB 20.09 MiB 2.35 MiB
e0624b6 17.74 MiB 20.10 MiB 2.36 MiB

Previous results on branch: antonis/3859-newCaptureFeedbackAPI-Form-Snapshot

Startup times

Revision Plain With Sentry Diff
affe9b6 419.06 ms 412.18 ms -6.88 ms
4e4c632 558.49 ms 557.46 ms -1.03 ms

App size

Revision Plain With Sentry Diff
affe9b6 17.74 MiB 20.10 MiB 2.37 MiB
4e4c632 17.74 MiB 20.10 MiB 2.36 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 382.89 ms 446.10 ms 63.21 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI-Form

Startup times

Revision Plain With Sentry Diff
cadf235+dirty 455.51 ms 451.64 ms -3.87 ms
d33790a+dirty 404.87 ms 473.06 ms 68.19 ms
26fc306+dirty 382.83 ms 435.31 ms 52.48 ms
38a278b+dirty 392.43 ms 442.41 ms 49.97 ms
edc8020+dirty 393.94 ms 407.87 ms 13.93 ms
03c9048+dirty 397.35 ms 417.73 ms 20.37 ms
1dd8d17+dirty 383.20 ms 432.62 ms 49.41 ms
0781f75+dirty 406.72 ms 454.80 ms 48.08 ms
a06f6ba+dirty 381.50 ms 429.77 ms 48.27 ms
db1844e+dirty 376.33 ms 428.67 ms 52.34 ms

App size

Revision Plain With Sentry Diff
cadf235+dirty 7.15 MiB 8.37 MiB 1.22 MiB
d33790a+dirty 7.15 MiB 8.38 MiB 1.23 MiB
26fc306+dirty 7.15 MiB 8.37 MiB 1.22 MiB
38a278b+dirty 7.15 MiB 8.38 MiB 1.23 MiB
edc8020+dirty 7.15 MiB 8.38 MiB 1.23 MiB
03c9048+dirty 7.15 MiB 8.38 MiB 1.23 MiB
1dd8d17+dirty 7.15 MiB 8.38 MiB 1.23 MiB
0781f75+dirty 7.15 MiB 8.37 MiB 1.22 MiB
a06f6ba+dirty 7.15 MiB 8.37 MiB 1.22 MiB
db1844e+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Previous results on branch: antonis/3859-newCaptureFeedbackAPI-Form-Snapshot

Startup times

Revision Plain With Sentry Diff
4e4c632+dirty 399.53 ms 447.02 ms 47.49 ms
affe9b6+dirty 363.19 ms 417.26 ms 54.07 ms

App size

Revision Plain With Sentry Diff
4e4c632+dirty 7.15 MiB 8.38 MiB 1.23 MiB
affe9b6+dirty 7.15 MiB 8.38 MiB 1.23 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.57 ms 1225.85 ms -0.72 ms
Size 2.36 MiB 3.13 MiB 782.75 KiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI-Form

Startup times

Revision Plain With Sentry Diff
a06f6ba+dirty 1230.45 ms 1227.09 ms -3.36 ms
1dd8d17+dirty 1235.22 ms 1218.96 ms -16.27 ms
0781f75+dirty 1222.19 ms 1222.11 ms -0.08 ms
cadf235+dirty 1223.89 ms 1236.22 ms 12.33 ms
38a278b+dirty 1233.02 ms 1233.82 ms 0.80 ms
a3ba405+dirty 1223.00 ms 1219.06 ms -3.94 ms
db1844e+dirty 1230.79 ms 1234.22 ms 3.43 ms
e0624b6+dirty 1221.86 ms 1226.42 ms 4.57 ms
26fc306+dirty 1227.25 ms 1225.85 ms -1.40 ms
50c70c0+dirty 1228.06 ms 1224.43 ms -3.64 ms

App size

Revision Plain With Sentry Diff
a06f6ba+dirty 2.36 MiB 3.11 MiB 761.35 KiB
1dd8d17+dirty 2.36 MiB 3.11 MiB 761.66 KiB
0781f75+dirty 2.36 MiB 3.11 MiB 761.35 KiB
cadf235+dirty 2.36 MiB 3.11 MiB 761.47 KiB
38a278b+dirty 2.36 MiB 3.13 MiB 782.12 KiB
a3ba405+dirty 2.36 MiB 3.11 MiB 760.99 KiB
db1844e+dirty 2.36 MiB 3.13 MiB 782.13 KiB
e0624b6+dirty 2.36 MiB 3.11 MiB 761.16 KiB
26fc306+dirty 2.36 MiB 3.11 MiB 761.18 KiB
50c70c0+dirty 2.36 MiB 3.11 MiB 760.92 KiB

Previous results on branch: antonis/3859-newCaptureFeedbackAPI-Form-Snapshot

Startup times

Revision Plain With Sentry Diff
4e4c632+dirty 1228.68 ms 1221.14 ms -7.54 ms
affe9b6+dirty 1229.02 ms 1233.29 ms 4.27 ms

App size

Revision Plain With Sentry Diff
4e4c632+dirty 2.36 MiB 3.11 MiB 761.64 KiB
affe9b6+dirty 2.36 MiB 3.11 MiB 761.73 KiB

@antonis antonis marked this pull request as ready for review December 16, 2024 15:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.47 ms 1231.02 ms -3.45 ms
Size 2.92 MiB 3.69 MiB 793.84 KiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI-Form

Startup times

Revision Plain With Sentry Diff
a06f6ba+dirty 1235.31 ms 1238.76 ms 3.45 ms
1dd8d17+dirty 1229.28 ms 1224.92 ms -4.36 ms
0781f75+dirty 1247.90 ms 1237.11 ms -10.79 ms
cadf235+dirty 1225.19 ms 1231.65 ms 6.47 ms
38a278b+dirty 1247.80 ms 1244.61 ms -3.18 ms
a3ba405+dirty 1229.31 ms 1228.16 ms -1.14 ms
db1844e+dirty 1231.94 ms 1238.86 ms 6.92 ms
e0624b6+dirty 1229.19 ms 1232.18 ms 3.00 ms
26fc306+dirty 1229.10 ms 1227.88 ms -1.22 ms
50c70c0+dirty 1226.61 ms 1225.02 ms -1.59 ms

App size

Revision Plain With Sentry Diff
a06f6ba+dirty 2.92 MiB 3.67 MiB 773.87 KiB
1dd8d17+dirty 2.92 MiB 3.67 MiB 774.21 KiB
0781f75+dirty 2.92 MiB 3.67 MiB 773.83 KiB
cadf235+dirty 2.92 MiB 3.67 MiB 773.97 KiB
38a278b+dirty 2.92 MiB 3.69 MiB 793.49 KiB
a3ba405+dirty 2.92 MiB 3.67 MiB 773.65 KiB
db1844e+dirty 2.92 MiB 3.69 MiB 793.48 KiB
e0624b6+dirty 2.92 MiB 3.67 MiB 773.62 KiB
26fc306+dirty 2.92 MiB 3.67 MiB 773.77 KiB
50c70c0+dirty 2.92 MiB 3.67 MiB 773.48 KiB

Previous results on branch: antonis/3859-newCaptureFeedbackAPI-Form-Snapshot

Startup times

Revision Plain With Sentry Diff
4e4c632+dirty 1226.86 ms 1239.10 ms 12.24 ms
affe9b6+dirty 1233.31 ms 1239.96 ms 6.65 ms

App size

Revision Plain With Sentry Diff
4e4c632+dirty 2.92 MiB 3.67 MiB 774.23 KiB
affe9b6+dirty 2.92 MiB 3.67 MiB 774.30 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antonis