Feat: add spotlight vscode task #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-zimerman
requested review from
krystofwoldrich and
antonis
as code owners
|
antonis
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
LGTM and works as described 🚀
Thank you for adding this @lucas-zimerman 🙇
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 13f280b | 486.16 ms | 472.45 ms | -13.71 ms |
| 9a3ca65+dirty | 326.93 ms | 330.14 ms | 3.21 ms |
| e1ea4a8 | 506.82 ms | 510.48 ms | 3.66 ms |
| 205982c | 504.41 ms | 505.70 ms | 1.29 ms |
| f06c879 | 408.41 ms | 424.54 ms | 16.13 ms |
| 83f6f6c | 418.83 ms | 410.94 ms | -7.89 ms |
| 22e31b6 | 396.48 ms | 419.64 ms | 23.16 ms |
| 7bc4d75 | 488.76 ms | 473.28 ms | -15.48 ms |
| 3aecc61 | 479.21 ms | 462.92 ms | -16.29 ms |
| 4a6664f | 548.79 ms | 585.00 ms | 36.21 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 13f280b | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 9a3ca65+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| e1ea4a8 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 205982c | 17.74 MiB | 20.10 MiB | 2.36 MiB |
| f06c879 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
| 83f6f6c | 17.74 MiB | 20.09 MiB | 2.35 MiB |
| 22e31b6 | 17.73 MiB | 19.84 MiB | 2.10 MiB |
| 7bc4d75 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 3aecc61 | 17.74 MiB | 20.10 MiB | 2.36 MiB |
| 4a6664f | 17.73 MiB | 19.94 MiB | 2.21 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 416f465+dirty | 1221.56 ms | 1226.48 ms | 4.92 ms |
| 5571a20+dirty | 1203.57 ms | 1204.57 ms | 1.00 ms |
| 15c80ab+dirty | 1223.74 ms | 1228.96 ms | 5.22 ms |
| 62a750b+dirty | 1216.60 ms | 1229.14 ms | 12.54 ms |
| 2ec71da+dirty | 1225.85 ms | 1231.57 ms | 5.72 ms |
| 75774ea+dirty | 1231.33 ms | 1243.39 ms | 12.06 ms |
| 6e8584e+dirty | 1274.50 ms | 1296.82 ms | 22.32 ms |
| 9cd0e9f+dirty | 1224.94 ms | 1239.88 ms | 14.94 ms |
| 9282172+dirty | 1237.27 ms | 1242.20 ms | 4.94 ms |
| d8668ce+dirty | 1225.18 ms | 1228.08 ms | 2.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 416f465+dirty | 2.36 MiB | 3.11 MiB | 759.80 KiB |
| 5571a20+dirty | 2.36 MiB | 2.92 MiB | 569.93 KiB |
| 15c80ab+dirty | 2.36 MiB | 2.83 MiB | 474.49 KiB |
| 62a750b+dirty | 2.36 MiB | 2.92 MiB | 570.00 KiB |
| 2ec71da+dirty | 2.36 MiB | 3.13 MiB | 784.66 KiB |
| 75774ea+dirty | 2.36 MiB | 3.10 MiB | 757.87 KiB |
| 6e8584e+dirty | 2.36 MiB | 2.88 MiB | 533.17 KiB |
| 9cd0e9f+dirty | 2.36 MiB | 3.08 MiB | 735.56 KiB |
| 9282172+dirty | 2.36 MiB | 3.11 MiB | 759.89 KiB |
| d8668ce+dirty | 2.36 MiB | 3.08 MiB | 737.08 KiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 416f465+dirty | 1232.48 ms | 1233.26 ms | 0.78 ms |
| 5571a20+dirty | 1228.09 ms | 1233.45 ms | 5.36 ms |
| 15c80ab+dirty | 1248.41 ms | 1251.24 ms | 2.83 ms |
| 62a750b+dirty | 1228.12 ms | 1230.53 ms | 2.41 ms |
| 2ec71da+dirty | 1230.29 ms | 1239.50 ms | 9.21 ms |
| 75774ea+dirty | 1235.23 ms | 1235.02 ms | -0.21 ms |
| 6e8584e+dirty | 1271.71 ms | 1281.26 ms | 9.55 ms |
| 9cd0e9f+dirty | 1244.61 ms | 1247.43 ms | 2.82 ms |
| 9282172+dirty | 1227.60 ms | 1232.69 ms | 5.09 ms |
| d8668ce+dirty | 1249.70 ms | 1242.31 ms | -7.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 416f465+dirty | 2.92 MiB | 3.67 MiB | 772.44 KiB |
| 5571a20+dirty | 2.92 MiB | 3.48 MiB | 575.54 KiB |
| 15c80ab+dirty | 2.92 MiB | 3.39 MiB | 481.56 KiB |
| 62a750b+dirty | 2.92 MiB | 3.48 MiB | 575.59 KiB |
| 2ec71da+dirty | 2.92 MiB | 3.69 MiB | 791.06 KiB |
| 75774ea+dirty | 2.92 MiB | 3.66 MiB | 763.01 KiB |
| 6e8584e+dirty | 2.92 MiB | 3.44 MiB | 536.52 KiB |
| 9cd0e9f+dirty | 2.92 MiB | 3.64 MiB | 741.23 KiB |
| 9282172+dirty | 2.92 MiB | 3.67 MiB | 772.46 KiB |
| d8668ce+dirty | 2.92 MiB | 3.64 MiB | 742.99 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
A shortcut to open spotlight UI from VSCode
From the terminal UI, on the options for opening a new terminal, you can select to run a task
Then on top you will see an option to run spotlight, after clicking it, a new terminal will open and spotlight will be ready/listening your events.
💡 Motivation and Context
It makes the process to open spotlight from VS Code easier
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog