Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Use regex to extract URL from DSN for filtering breadcrumbs #4395

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(core): Use regex to extract URL from DSN for filtering breadcrumbs #4395

wants to merge 2 commits into from
+11 −13

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Dec 19, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Uses regex to extract URL from DSN for filtering breadcrumbs instead of relying on the implementation of the URL protocol #4240 that may result in errors like the following on some environments:

Failed to extract url from DSN [Error: URL.protocol is not implemented] [Component Stack]

💡 Motivation and Context

See #4375 (comment)

💚 How did you test it?

Manual testing, Existing unit tests

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis marked this pull request as ready for review December 19, 2024 13:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 431.94 ms 424.68 ms -7.26 ms
Size 17.74 MiB 20.10 MiB 2.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d8668ce 452.13 ms 435.06 ms -17.07 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
5bb8d5f 431.21 ms 459.40 ms 28.19 ms
07e58c9 495.04 ms 489.73 ms -5.31 ms
700cbf4 425.56 ms 436.26 ms 10.70 ms
27ef4ee 317.40 ms 321.70 ms 4.30 ms
0677344 327.74 ms 337.14 ms 9.40 ms
13f280b 486.16 ms 472.45 ms -13.71 ms
2534337 394.15 ms 415.12 ms 20.97 ms
baa882f 354.93 ms 356.18 ms 1.25 ms

App size

Revision Plain With Sentry Diff
d8668ce 17.74 MiB 20.08 MiB 2.34 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
5bb8d5f 17.73 MiB 19.93 MiB 2.20 MiB
07e58c9 17.74 MiB 20.08 MiB 2.34 MiB
700cbf4 17.73 MiB 20.07 MiB 2.33 MiB
27ef4ee 17.73 MiB 19.82 MiB 2.08 MiB
0677344 17.73 MiB 19.81 MiB 2.07 MiB
13f280b 17.74 MiB 20.08 MiB 2.34 MiB
2534337 17.73 MiB 19.84 MiB 2.11 MiB
baa882f 17.73 MiB 20.06 MiB 2.33 MiB

Previous results on branch: antonis/extract-url-with-regex

Startup times

Revision Plain With Sentry Diff
fb2547b 456.13 ms 481.60 ms 25.47 ms

App size

Revision Plain With Sentry Diff
fb2547b 17.74 MiB 20.10 MiB 2.36 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 485.25 ms 471.55 ms -13.70 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4cc5c27+dirty 398.36 ms 452.50 ms 54.14 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
ed3d77e+dirty 366.04 ms 411.33 ms 45.28 ms
8de2810+dirty 368.43 ms 412.20 ms 43.77 ms
70e6261+dirty 395.08 ms 408.12 ms 13.04 ms
31fcca2+dirty 366.64 ms 395.78 ms 29.14 ms
63ed251+dirty 485.02 ms 531.16 ms 46.14 ms
34aba08+dirty 331.79 ms 376.69 ms 44.91 ms
db44eaf+dirty 394.26 ms 438.88 ms 44.62 ms
9282172+dirty 363.57 ms 399.78 ms 36.20 ms

App size

Revision Plain With Sentry Diff
4cc5c27+dirty 7.15 MiB 8.22 MiB 1.07 MiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
ed3d77e+dirty 7.15 MiB 8.35 MiB 1.21 MiB
8de2810+dirty 7.15 MiB 8.35 MiB 1.20 MiB
70e6261+dirty 7.15 MiB 8.21 MiB 1.07 MiB
31fcca2+dirty 7.15 MiB 8.18 MiB 1.03 MiB
63ed251+dirty 7.15 MiB 8.35 MiB 1.20 MiB
34aba08+dirty 7.15 MiB 8.07 MiB 946.13 KiB
db44eaf+dirty 7.15 MiB 8.36 MiB 1.21 MiB
9282172+dirty 7.15 MiB 8.37 MiB 1.22 MiB

Previous results on branch: antonis/extract-url-with-regex

Startup times

Revision Plain With Sentry Diff
fb2547b+dirty 388.51 ms 464.65 ms 76.14 ms

App size

Revision Plain With Sentry Diff
fb2547b+dirty 7.15 MiB 8.38 MiB 1.23 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1238.58 ms 1224.85 ms -13.73 ms
Size 2.92 MiB 3.69 MiB 790.66 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c6f01ea+dirty 1229.52 ms 1237.16 ms 7.64 ms
9f0f6c8+dirty 1236.94 ms 1245.41 ms 8.47 ms
4a6664f+dirty 1218.77 ms 1221.07 ms 2.30 ms
63ed251+dirty 1223.27 ms 1222.94 ms -0.33 ms
d361d38+dirty 1272.96 ms 1291.70 ms 18.74 ms
9433f35+dirty 1232.24 ms 1232.74 ms 0.50 ms
8ab11b6+dirty 1222.91 ms 1216.08 ms -6.83 ms
a989877+dirty 1222.90 ms 1219.89 ms -3.00 ms
1faf8e3+dirty 1223.38 ms 1220.56 ms -2.82 ms
ed3d77e+dirty 1246.19 ms 1244.00 ms -2.19 ms

App size

Revision Plain With Sentry Diff
c6f01ea+dirty 2.92 MiB 3.69 MiB 789.94 KiB
9f0f6c8+dirty 2.92 MiB 3.67 MiB 771.98 KiB
4a6664f+dirty 2.92 MiB 3.60 MiB 702.09 KiB
63ed251+dirty 2.92 MiB 3.66 MiB 757.10 KiB
d361d38+dirty 2.92 MiB 3.41 MiB 503.57 KiB
9433f35+dirty 2.92 MiB 3.41 MiB 503.55 KiB
8ab11b6+dirty 2.92 MiB 3.67 MiB 772.38 KiB
a989877+dirty 2.92 MiB 3.66 MiB 757.66 KiB
1faf8e3+dirty 2.92 MiB 3.64 MiB 742.61 KiB
ed3d77e+dirty 2.92 MiB 3.66 MiB 758.57 KiB

Previous results on branch: antonis/extract-url-with-regex

Startup times

Revision Plain With Sentry Diff
fb2547b+dirty 1242.14 ms 1240.33 ms -1.82 ms

App size

Revision Plain With Sentry Diff
fb2547b+dirty 2.92 MiB 3.69 MiB 790.20 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.64 ms 1229.61 ms 2.97 ms
Size 2.36 MiB 3.12 MiB 779.48 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c6f01ea+dirty 1227.10 ms 1235.35 ms 8.24 ms
9f0f6c8+dirty 1231.60 ms 1232.73 ms 1.12 ms
4a6664f+dirty 1209.49 ms 1208.63 ms -0.86 ms
63ed251+dirty 1232.55 ms 1238.77 ms 6.22 ms
d361d38+dirty 1246.04 ms 1267.12 ms 21.08 ms
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
8ab11b6+dirty 1203.23 ms 1206.02 ms 2.79 ms
a989877+dirty 1228.56 ms 1227.71 ms -0.85 ms
1faf8e3+dirty 1214.87 ms 1222.83 ms 7.97 ms
ed3d77e+dirty 1214.61 ms 1205.83 ms -8.78 ms

App size

Revision Plain With Sentry Diff
c6f01ea+dirty 2.36 MiB 3.12 MiB 778.61 KiB
9f0f6c8+dirty 2.36 MiB 3.10 MiB 759.48 KiB
4a6664f+dirty 2.36 MiB 3.04 MiB 696.39 KiB
63ed251+dirty 2.36 MiB 3.10 MiB 752.55 KiB
d361d38+dirty 2.36 MiB 2.85 MiB 499.84 KiB
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
8ab11b6+dirty 2.36 MiB 3.11 MiB 759.83 KiB
a989877+dirty 2.36 MiB 3.10 MiB 752.40 KiB
1faf8e3+dirty 2.36 MiB 3.08 MiB 736.75 KiB
ed3d77e+dirty 2.36 MiB 3.10 MiB 753.32 KiB

Previous results on branch: antonis/extract-url-with-regex

Startup times

Revision Plain With Sentry Diff
fb2547b+dirty 1232.60 ms 1244.00 ms 11.40 ms

App size

Revision Plain With Sentry Diff
fb2547b+dirty 2.36 MiB 3.12 MiB 778.85 KiB

@antonis antonis mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antonis