Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check if symfony/http-client is installed #858

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix check if symfony/http-client is installed #858

merged 1 commit into from
Jul 2, 2024

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Jul 1, 2024

We need to check if Symfony\Component\HttpClient\HttpClient exists, as Symfony\Contracts\HttpClient\HttpClientInterface could be pulled in via symfony/contracts.

Fixes #855.

@cleptric cleptric self-assigned this Jul 1, 2024
@cleptric cleptric requested a review from stayallive July 1, 2024 20:51
@cleptric cleptric mentioned this pull request Jul 1, 2024
Closed
@cleptric cleptric merged commit bdcec61 into master Jul 2, 2024
33 checks passed
@cleptric cleptric deleted the fix-http-client-installed-check branch July 2, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

@stayallive stayallive Awaiting requested review from stayallive

Assignees

@cleptric cleptric

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TraceableResponseForV4::getInfo must be compatible with ResponseInterface::getInfo
2 participants
@cleptric @Jean85