fix modal legend issues

getsentry · Sep 27, 2024 · 0afb7e1 · 0afb7e1
1 parent c552716
commit 0afb7e1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 24 deletions.
diff --git a/static/app/components/modals/widgetViewerModal.tsx b/static/app/components/modals/widgetViewerModal.tsx
@@ -130,7 +130,13 @@ const shouldWidgetCardChartMemo = (prevProps, props) => {
   );
   const isNotTopNWidget =
     props.widget.displayType !== DisplayType.TOP_N && !defined(props.widget.limit);
-  return selectionMatches && chartZoomOptionsMatches && (sortMatches || isNotTopNWidget);
+  const legendMatches = isEqual(props.legendOptions, prevProps.legendOptions);
+  return (
+    selectionMatches &&
+    chartZoomOptionsMatches &&
+    (sortMatches || isNotTopNWidget) &&
+    legendMatches
+  );
 };
 
 // WidgetCardChartContainer and WidgetCardChart rerenders if selection was changed.
@@ -221,27 +227,6 @@ function WidgetViewerModal(props: Props) {
     useState<PageFilters>(locationPageFilter);
   const modalChartSelection = useRef(modalTableSelection);
 
-  useEffect(() => {
-    // have the query legend values update
-    const legendData = seriesData?.reduce((prevSeries, series) => {
-      prevSeries[series.seriesName] = series.seriesName === 'Releases' ? false : true;
-      return prevSeries;
-    }, {});
-
-    const definedLegendData = legendData ? legendData : {};
-
-    router.replace({
-      pathname: location.pathname,
-      query: {
-        ...location.query,
-        [WidgetViewerQueryField.LEGEND]: Object.keys(definedLegendData).filter(
-          key => definedLegendData[key]
-        ),
-      },
-    });
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, []);
-
   // Detect when a user clicks back and set the PageFilter state to match the location
   // We need to use useEffect to prevent infinite looping rerenders due to the setModalTableSelection call
   useEffect(() => {

diff --git a/static/app/views/dashboards/widgetCard/chart.tsx b/static/app/views/dashboards/widgetCard/chart.tsx
@@ -535,8 +535,7 @@ class WidgetCardChart extends Component<WidgetCardChartProps> {
               memoized
             >
               {({releaseSeries}) => {
-                location.query.unselectedSeries = 'Releases';
-                legend.selected = getSeriesSelection(location);
+                legend.selected = {Releases: false, ...legend.selected};
 
                 return (
                   <TransitionChart loading={loading} reloading={loading}>