Fix slackbot (#54457)

Typo in the payload being sent to the webhook, hence the 400 status code
error.
I added better testing, as well as not raising an error (as to keep the
automator running in case this fails again).

src/sentry/options/defaults.py

@@ -1455,3 +1455,9 @@
     default=[],
     flags=FLAG_PRIORITIZE_DISK | FLAG_AUTOMATOR_MODIFIABLE,
 )
+
+register(
+    "options_automator_slack_webhook_enabled",
+    default=True,
+    flags=FLAG_AUTOMATOR_MODIFIABLE,
+)

src/sentry/runner/commands/presenters/slackpresenter.py

@@ -3,6 +3,7 @@
 import requests
 from django.conf import settings
 
+from sentry import options
 from sentry.runner.commands.presenters.optionspresenter import OptionsPresenter
 from sentry.utils import json
 
@@ -29,15 +30,19 @@ def __init__(self) -> None:
 
     @staticmethod
     def is_slack_enabled():
-        if not settings.OPTIONS_AUTOMATOR_SLACK_WEBHOOK_URL:
+
+        if not (
+            options.get("options_automator_slack_webhook_enabled")
+            and settings.OPTIONS_AUTOMATOR_SLACK_WEBHOOK_URL
+        ):
             return False
         try:
             test_payload: dict = {
                 "drifted_options": [],
                 "updated_options": [],
                 "set_options": [],
                 "unset_options": [],
-                "not_writable": [],
+                "not_writable_options": [],
                 "unregistered_options": [],
                 "invalid_type_options": [],
             }

tests/sentry/runner/commands/presenters/test_slackpresenter.py

@@ -16,6 +16,7 @@ def setup(self):
     def test_is_slack_enabled(self):
         responses.add(responses.POST, "https://test/", status=200)
 
+        assert self.slackPresenter.is_slack_enabled()
         self.slackPresenter.set("option1", "value1")
         self.slackPresenter.set("option2", "value2")
 
@@ -75,5 +76,5 @@ def test_is_slack_enabled(self):
             ],
         }
 
-        assert responses.calls[0].response.status_code == 200
-        assert expected_json_data == json.loads(responses.calls[0].request.body)
+        assert responses.calls[1].response.status_code == 200
+        assert expected_json_data == json.loads(responses.calls[1].request.body)