Skip to content

Commit

Permalink
cosmetic change, change parameter name
Browse files Browse the repository at this point in the history
  • Loading branch information
RaduW committed Jul 4, 2023
1 parent eb57fee commit 1c43854
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/sentry/sentry_metrics/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def reverse_resolve_tag_value(


def bulk_reverse_resolve_tag_value(
use_case_id: UseCaseID, org_id: int, indexes: Collection[Union[int, str, None]]
use_case_id: UseCaseID, org_id: int, values: Collection[Union[int, str, None]]
) -> Mapping[Union[int, str], str]:
"""
Reverse resolves a mixture of indexes and strings in bulk
Expand All @@ -56,11 +56,11 @@ def bulk_reverse_resolve_tag_value(
ret_val: Dict[Union[int, str], str] = {}

indexes_to_resolve: Set[int] = set()
for index in indexes:
if isinstance(index, str):
ret_val[index] = index # we already have a string no need to reverse resolve it
elif isinstance(index, int) and index > 0: # resolve valid int, do nothing for None
indexes_to_resolve.add(index)
for value in values:
if isinstance(value, str):
ret_val[value] = value # we already have a string no need to reverse resolve it
elif isinstance(value, int) and value > 0: # resolve valid int, do nothing for None
indexes_to_resolve.add(value)

resolved_indexes = cast(
Mapping[Union[int, str], str],
Expand Down

0 comments on commit 1c43854

Please sign in to comment.