Skip to content

Commit

Permalink
nit(anomaly detection): edit copy to fit spec (#76578)
Browse files Browse the repository at this point in the history
<img width="1016" alt="Screenshot 2024-08-26 at 3 41 20 PM"
src="https://github.com/user-attachments/assets/58c5c1a3-d2a0-493f-a982-8b125621488f">
  • Loading branch information
mifu67 committed Aug 26, 2024
1 parent 8e5c6ce commit 480e12e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions static/app/views/alerts/rules/metric/ruleForm.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -373,16 +373,16 @@ describe('Incident Rules Form', () => {
},
});
await userEvent.click(
screen.getByText('Anomaly: when evaluated values are outside of expected bounds')
screen.getByText('Anomaly: whenever values are outside of expected bounds')
);

expect(
await screen.findByLabelText(
'Anomaly: when evaluated values are outside of expected bounds'
'Anomaly: whenever values are outside of expected bounds'
)
).toBeChecked();
expect(
await screen.findByRole('textbox', {name: 'Sensitivity'})
await screen.findByRole('textbox', {name: 'Level of responsiveness'})
).toBeInTheDocument();
await userEvent.click(screen.getByLabelText('Save Rule'));

Expand Down Expand Up @@ -528,7 +528,7 @@ describe('Incident Rules Form', () => {
},
});
const anomaly_option = await screen.findByText(
'Anomaly: when evaluated values are outside of expected bounds'
'Anomaly: whenever values are outside of expected bounds'
);
expect(anomaly_option).toBeInTheDocument();
});
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/alerts/rules/metric/thresholdTypeForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function ThresholdTypeForm({
if (hasAnomalyDetection) {
thresholdTypeChoices.push([
AlertRuleComparisonType.DYNAMIC,
'Anomaly: when evaluated values are outside of expected bounds',
'Anomaly: whenever values are outside of expected bounds',
] as RadioOption);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ function SensitivityFormItem({
}: SensitivityFormItemProps) {
return (
<StyledField
label={'Sensitivity'}
label={'Level of responsiveness'}
id={'sensitivity'}
help={
'Lower sensitivity will alert you only when anomalies are larger, higher sensitivity will alert you and your team for even small deviations.'
'Choose your level of anomaly responsiveness. Higher thresholds means alerts for most anomalies. Lower thresholds means alerts only for larger ones.'
}
required
>
Expand Down Expand Up @@ -80,9 +80,9 @@ function DirectionFormItem({
}: DirectionFormItemProps) {
return (
<StyledField
label={'Direction'}
label={'Direction of anomaly movement'}
help={
'Indicate if you want to be alerted of anomalies above your set bounds, below, or both.'
'Decide if you want to be alerted to anomalies that are moving above, below, or in both directions in relation to your threshold.'
}
required
>
Expand Down

0 comments on commit 480e12e

Please sign in to comment.