Merge branch 'master' into priscila/ref/stats/add-links-to-docs

getsentry · Sep 23, 2024 · 500b74a · 500b74a
2 parents 7af7677 + 01fffb9
commit 500b74a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/static/app/gettingStartedDocs/javascript/vue.tsx b/static/app/gettingStartedDocs/javascript/vue.tsx
@@ -222,7 +222,9 @@ function getSiblingImportsSetupConfiguration(siblingOption: string): string {
   switch (siblingOption) {
     case VueVersion.VUE3:
       return `import {createApp} from "vue";
-          import {createRouter} from "vue-router";`;
+          import {createRouter} from "vue-router";
+          import router from "./router";
+          `;
     case VueVersion.VUE2:
     default:
       return `import Vue from "vue";
@@ -251,9 +253,6 @@ function getVueConstSetup(siblingOption: string): string {
           const app = createApp({
             // ...
           });
-          const router = createRouter({
-            // ...
-          });
           `;
     case VueVersion.VUE2:
       return `

diff --git a/static/app/views/onboarding/components/useOnboardingQueryParams.tsx b/static/app/views/onboarding/components/useOnboardingQueryParams.tsx
@@ -10,10 +10,6 @@ type QueryValues = {
    * Used to show product selection (error monitoring, tracing, profiling and session replay) for certain platforms, e.g. javascript-react
    */
   product: string[];
-  /**
-   * Used to show the loader script for when the platform is javascript
-   */
-  showLoader: boolean;
   /**
    * Used to show or not the integration onboarding for certain platforms, e.g. AWS (python)
    */
@@ -29,7 +25,6 @@ export function useOnboardingQueryParams(): [
   const params = useLocationQuery({
     fields: {
       product: decodeList,
-      showLoader: decodeBoolean,
       showManualSetup: decodeBoolean,
     },
   });