Skip to content

Commit

Permalink
Removes snuba task annotations due to weird interaction between silo …
Browse files Browse the repository at this point in the history
…mode and test
  • Loading branch information
GabeVillalobos committed Aug 4, 2023
1 parent 5c65eba commit 56b8b5f
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/sentry/snuba/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
from sentry import features
from sentry.models import Environment
from sentry.services.hybrid_cloud.organization import organization_service
from sentry.silo import SiloMode
from sentry.snuba.dataset import Dataset, EntityKey
from sentry.snuba.entity_subscription import (
BaseEntitySubscription,
Expand All @@ -33,12 +32,13 @@
SUBSCRIPTION_STATUS_MAX_AGE = timedelta(minutes=10)


# TODO(hybrid-cloud): Mark this as region silo only once testing/decorator
# interaction is cleaned up
@instrumented_task(
name="sentry.snuba.tasks.create_subscription_in_snuba",
queue="subscriptions",
default_retry_delay=5,
max_retries=5,
silo_mode=SiloMode.REGION,
)
def create_subscription_in_snuba(query_subscription_id, **kwargs):
"""
Expand Down Expand Up @@ -82,7 +82,6 @@ def create_subscription_in_snuba(query_subscription_id, **kwargs):
queue="subscriptions",
default_retry_delay=5,
max_retries=5,
silo_mode=SiloMode.REGION,
)
def update_subscription_in_snuba(
query_subscription_id,
Expand Down Expand Up @@ -153,7 +152,6 @@ def update_subscription_in_snuba(
queue="subscriptions",
default_retry_delay=5,
max_retries=5,
silo_mode=SiloMode.REGION,
)
def delete_subscription_from_snuba(query_subscription_id, **kwargs):
"""
Expand Down Expand Up @@ -265,7 +263,6 @@ def _delete_from_snuba(dataset: Dataset, subscription_id: str, entity_key: Entit
@instrumented_task(
name="sentry.snuba.tasks.subscription_checker",
queue="subscriptions",
silo_mode=SiloMode.REGION,
)
def subscription_checker(**kwargs):
"""
Expand Down

0 comments on commit 56b8b5f

Please sign in to comment.