fix(insights): fix broken issue link

getsentry · Sep 20, 2024 · 790eca3 · 790eca3
1 parent d160151
commit 790eca3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/static/app/views/insights/common/components/issues.tsx b/static/app/views/insights/common/components/issues.tsx
@@ -32,7 +32,7 @@ function Issue({data}: {data: Group}) {
  return (
  <StyledPanelItem as="tr">
  <IssueSummaryWrapper>
- <IssueSummary data={data} organization={organization} event_id={'0'} />
+ <IssueSummary data={data} organization={organization} />
  <EventOrGroupExtraDetails data={data} />
  </IssueSummaryWrapper>
  <ChartWrapper>

diff --git a/static/app/views/performance/newTraceDetails/traceDrawer/details/issues/issueSummary.tsx b/static/app/views/performance/newTraceDetails/traceDrawer/details/issues/issueSummary.tsx
@@ -16,8 +16,8 @@ import useOrganization from 'sentry/utils/useOrganization';
 
 interface EventOrGroupHeaderProps {
  data: Group;
- event_id: string;
  organization: Organization;
+ event_id?: string;
 }
 
 /**
@@ -51,7 +51,7 @@ function IssueTitleChildren(props: IssueTitleChildrenProps) {
 
 interface IssueTitleProps {
  data: Group;
- event_id: string;
+ event_id?: string;
 }
 function IssueTitle(props: IssueTitleProps) {
  const organization = useOrganization();
@@ -71,7 +71,9 @@ function IssueTitle(props: IssueTitleProps) {
  <TitleWithLink
  {...commonEleProps}
  to={{
- pathname: `/organizations/${organization.slug}/issues/${props.data.id}/events/${props.event_id}/`,
+ pathname: props.event_id
+ ? `/organizations/${organization.slug}/issues/${props.data.id}/events/${props.event_id}/`
+ : `/organizations/${organization.slug}/issues/${props.data.id}/`,
  }}
  >
  <IssueTitleChildren data={props.data} organization={organization} />