fix(update-activity): Fix updateActivty for groupStore

getsentry · Oct 3, 2023 · 8c2ef32 · 8c2ef32
1 parent 2500a36
commit 8c2ef32
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 4 deletions.
diff --git a/static/app/actionCreators/group.tsx b/static/app/actionCreators/group.tsx
@@ -188,7 +188,7 @@ export function updateNote(
  id: string,
  oldText: string
 ) {
- GroupStore.updateActivity(group.id, id, {data: {text: note.text}});
+ GroupStore.updateActivity(group.id, id, {text: note.text});
 
  const promise = api.requestPromise(
  `/organizations/${orgSlug}/issues/${group.id}/comments/${id}/`,
@@ -198,7 +198,7 @@ export function updateNote(
  }
  );
 
- promise.catch(() => GroupStore.updateActivity(group.id, id, {data: {text: oldText}}));
+ promise.catch(() => GroupStore.updateActivity(group.id, id, {text: oldText}));
 
  return promise;
 }

diff --git a/static/app/stores/groupStore.spec.tsx b/static/app/stores/groupStore.spec.tsx
@@ -1,5 +1,7 @@
+import {Project} from 'sentry-fixture/project';
+
 import GroupStore from 'sentry/stores/groupStore';
-import {Group, GroupStats, TimeseriesValue} from 'sentry/types';
+import {Group, GroupActivityType, GroupStats, TimeseriesValue} from 'sentry/types';
 
 const MOCK_PROJECT = TestStubs.Project();
 
@@ -227,5 +229,25 @@ describe('GroupStore', function () {
  expect(GroupStore.items[0]).toEqual(assignedGroup);
  });
  });
+
+ describe('updateActivity()', function () {
+ it("should update activity data text'", function () {
+ GroupStore.items = [
+ g('1', {
+ activity: [
+ {
+ id: '1',
+ type: GroupActivityType.NOTE,
+ dateCreated: '',
+ project: Project(),
+ data: {text: 'Orginal Text'},
+ },
+ ],
+ }),
+ ];
+ GroupStore.updateActivity('1', '1', {text: 'Updated Text'});
+ expect(GroupStore.items[0].activity[0].data).toEqual({text: 'Updated Text'});
+ });
+ });
  });
 });
diff --git a/static/app/stores/groupStore.tsx b/static/app/stores/groupStore.tsx
@@ -33,7 +33,7 @@ interface InternalDefinition {
  pendingChanges: Map<ChangeId, Change>;
  removeActivity: (groupId: string, id: string) => number;
  statuses: Record<string, Record<string, boolean>>;
- updateActivity: (groupId: string, id: string, data: Partial<Activity>) => void;
+ updateActivity: (groupId: string, id: string, data: Partial<Activity['data']>) => void;
  updateItems: (itemIds: ItemIds) => void;
 }