fix(starfish): Add bitwise operator support to SQL parser (#54894)

These show up on occasion!
getsentry · Aug 17, 2023 · 8e90ede · 8e90ede
1 parent d5615b9
commit 8e90ede
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/static/app/views/starfish/utils/sqlish/SQLishParser.spec.tsx b/static/app/views/starfish/utils/sqlish/SQLishParser.spec.tsx
@@ -22,6 +22,10 @@ describe('SQLishParser', function () {
       'created >= %s', // Python-style
       'created >= $1', // Rails-style
       '@@ to_tsquery', // Postgres full-text search
+      'flags & %s)', // Bitwise AND
+      'flags | %s)', // Bitwise OR
+      'flags ^ %s)', // Bitwise XOR
+      'flags ~ %s)', // Bitwise NOT
     ])('Parses %s', sql => {
       expect(() => {
         parser.parse(sql);

diff --git a/static/app/views/starfish/utils/sqlish/sqlish.pegjs b/static/app/views/starfish/utils/sqlish/sqlish.pegjs
@@ -36,4 +36,4 @@ Whitespace
   = Whitespace:[\n\t ]+ { return { type: 'Whitespace', content: Whitespace.join("") } }
 
 GenericToken
-  = GenericToken:[a-zA-Z0-9"'`_\-.=><:,*;!\[\]?$%|/@]+ { return { type: 'GenericToken', content: GenericToken.join('') } }
+  = GenericToken:[a-zA-Z0-9"'`_\-.=><:,*;!\[\]?$%|/@&~^]+ { return { type: 'GenericToken', content: GenericToken.join('') } }