Fix error in JS A/B test code (#50229)

fixes SENTRY-1194
getsentry · Jun 2, 2023 · c2b643a · c2b643a
1 parent 25a294d
commit c2b643a
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/src/sentry/lang/javascript/processor.py b/src/sentry/lang/javascript/processor.py
@@ -2151,11 +2151,6 @@ def close(self):
 
             metrics.incr("sourcemaps.ab-test.performed")
 
-            # TODO: we currently have known differences:
-            # - python prefixes sourcemaps fetched by debug-id with `debug-id://`
-            # - some insignificant differences in source context application
-            #   related to different column offsets
-            # - python adds a `data.sourcemap` even if none was fetched successfully
             interesting_keys = {
                 "abs_path",
                 "filename",
@@ -2224,10 +2219,9 @@ def without_known_diffs(frame: dict) -> dict:
                         ):
                             # python emits a `debug-id://` prefix whereas symbolicator does not
                             # OR: python adds a `data.sourcemap` even though it could not be resolved
-                            if (
-                                python_frame.get("data.sourcemap", "").startswith("debug-id://")
-                                or symbolicator_frame.get("data.sourcemap") is None
-                            ):
+                            if (python_frame.get("data.sourcemap") or "").startswith(
+                                "debug-id://"
+                            ) or symbolicator_frame.get("data.sourcemap") is None:
                                 continue
 
                             # with minified files and high column numbers, we might have a difference in