ref(grouping-stacktrace-ui): Remove ui code (#76593)

getsentry · Aug 28, 2024 · d03b61d · d03b61d
1 parent eaceac4
commit d03b61d
Show file tree

Hide file tree

Showing 20 changed files with 19 additions and 447 deletions.
diff --git a/static/app/components/events/eventEntry.tsx b/static/app/components/events/eventEntry.tsx
@@ -40,10 +40,6 @@ function EventEntryContent({
  group,
  isShare,
 }: Props) {
- const hasHierarchicalGrouping =
- !!organization.features?.includes('grouping-stacktrace-ui') &&
- !!(event.metadata.current_tree_label || event.metadata.finest_tree_label);
-
  const groupingCurrentLevel = group?.metadata?.current_level;
 
  switch (entry.type) {
@@ -54,7 +50,6 @@ function EventEntryContent({
  data={entry.data}
  projectSlug={projectSlug}
  groupingCurrentLevel={groupingCurrentLevel}
- hasHierarchicalGrouping={hasHierarchicalGrouping}
  />
  );
 
@@ -71,7 +66,6 @@ function EventEntryContent({
  data={entry.data}
  projectSlug={projectSlug}
  groupingCurrentLevel={groupingCurrentLevel}
- hasHierarchicalGrouping={hasHierarchicalGrouping}
  />
  );
 
@@ -107,7 +101,6 @@ function EventEntryContent({
  data={entry.data}
  projectSlug={projectSlug}
  groupingCurrentLevel={groupingCurrentLevel}
- hasHierarchicalGrouping={hasHierarchicalGrouping}
  />
  );
 

diff --git a/static/app/components/events/interfaces/crashContent/exception/content.spec.tsx b/static/app/components/events/interfaces/crashContent/exception/content.spec.tsx
@@ -133,7 +133,6 @@ describe('Exception Content', function () {
  <Content
  type={StackType.ORIGINAL}
  groupingCurrentLevel={0}
- hasHierarchicalGrouping
  newestFirst
  stackView={StackView.APP}
  event={event}
@@ -199,7 +198,6 @@ describe('Exception Content', function () {
  render(
  <Content
  type={StackType.ORIGINAL}
- hasHierarchicalGrouping={false}
  stackView={StackView.APP}
  event={event}
  values={event.entries[0].data.values}
@@ -240,7 +238,6 @@ describe('Exception Content', function () {
 
  const defaultProps = {
  type: StackType.ORIGINAL,
- hasHierarchicalGrouping: false,
  newestFirst: true,
  platform: 'python' as const,
  stackView: StackView.APP,

diff --git a/static/app/components/events/interfaces/crashContent/exception/content.tsx b/static/app/components/events/interfaces/crashContent/exception/content.tsx
@@ -35,10 +35,7 @@ type Props = {
  stackView?: StackTraceProps['stackView'];
  threadId?: number;
 } & Pick<ExceptionType, 'values'> &
- Pick<
- React.ComponentProps<typeof StackTrace>,
- 'groupingCurrentLevel' | 'hasHierarchicalGrouping'
- >;
+ Pick<React.ComponentProps<typeof StackTrace>, 'groupingCurrentLevel'>;
 
 type CollapsedExceptionMap = {[exceptionId: number]: boolean};
 
@@ -127,7 +124,6 @@ export function Content({
  event,
  stackView,
  groupingCurrentLevel,
- hasHierarchicalGrouping,
  projectSlug,
  values,
  type,
@@ -221,7 +217,6 @@ export function Content({
  newestFirst={newestFirst}
  event={event}
  chainedException={values.length > 1}
- hasHierarchicalGrouping={hasHierarchicalGrouping}
  groupingCurrentLevel={groupingCurrentLevel}
  meta={meta?.[excIdx]?.stacktrace}
  threadId={threadId}

diff --git a/static/app/components/events/interfaces/crashContent/exception/index.tsx b/static/app/components/events/interfaces/crashContent/exception/index.tsx
@@ -10,7 +10,6 @@ import RawContent from './rawContent';
 
 type Props = {
  event: Event;
- hasHierarchicalGrouping: boolean;
  newestFirst: boolean;
  projectSlug: Project['slug'];
  stackType: StackType;
@@ -27,7 +26,6 @@ export function ExceptionContent({
  values,
  event,
  newestFirst,
- hasHierarchicalGrouping,
  groupingCurrentLevel,
  meta,
  threadId,
@@ -50,7 +48,6 @@ export function ExceptionContent({
  projectSlug={projectSlug}
  newestFirst={newestFirst}
  event={event}
- hasHierarchicalGrouping={hasHierarchicalGrouping}
  groupingCurrentLevel={groupingCurrentLevel}
  meta={meta}
  threadId={threadId}

diff --git a/static/app/components/events/interfaces/crashContent/exception/stackTrace.spec.tsx b/static/app/components/events/interfaces/crashContent/exception/stackTrace.spec.tsx
@@ -85,7 +85,6 @@ const props: React.ComponentProps<typeof ExceptionStacktraceContent> = {
  }),
  data: stacktrace,
  stacktrace,
- hasHierarchicalGrouping: false,
  groupingCurrentLevel: undefined,
  meta: undefined,
 };

diff --git a/static/app/components/events/interfaces/crashContent/exception/stackTrace.tsx b/static/app/components/events/interfaces/crashContent/exception/stackTrace.tsx
@@ -11,14 +11,12 @@ import {defined} from 'sentry/utils';
 import {isNativePlatform} from 'sentry/utils/platform';
 
 import StackTraceContent from '../stackTrace/content';
-import {HierarchicalGroupingContent} from '../stackTrace/hierarchicalGroupingContent';
 import {NativeContent} from '../stackTrace/nativeContent';
 
 type Props = {
  chainedException: boolean;
  data: ExceptionValue['stacktrace'];
  event: Event;
- hasHierarchicalGrouping: boolean;
  platform: PlatformKey;
  stackType: StackType;
  stacktrace: ExceptionValue['stacktrace'];
@@ -38,7 +36,6 @@ function StackTrace({
  platform,
  newestFirst,
  groupingCurrentLevel,
- hasHierarchicalGrouping,
  data,
  expandFirstFrame,
  event,
@@ -60,11 +57,7 @@ function StackTrace({
  <Panel dashedBorder>
  <EmptyMessage
  icon={<IconWarning size="xl" />}
- title={
- hasHierarchicalGrouping
- ? t('No relevant stack trace has been found!')
- : t('No app only stack trace has been found!')
- }
+ title={t('No app only stack trace has been found!')}
  />
  </Panel>
  );
@@ -101,21 +94,6 @@ function StackTrace({
  );
  }
 
- if (hasHierarchicalGrouping) {
- return (
- <HierarchicalGroupingContent
- data={data}
- expandFirstFrame={expandFirstFrame}
- includeSystemFrames={includeSystemFrames}
- groupingCurrentLevel={groupingCurrentLevel}
- platform={platform}
- newestFirst={newestFirst}
- event={event}
- meta={meta}
- />
- );
- }
-
  return (
  <StackTraceContent
  data={data}

diff --git a/static/app/components/events/interfaces/crashContent/index.spec.tsx b/static/app/components/events/interfaces/crashContent/index.spec.tsx
@@ -54,7 +54,6 @@ describe('CrashContent', function () {
  newestFirst
  exception={(proxiedExc as any).exception}
  projectSlug={ProjectFixture().slug}
- hasHierarchicalGrouping={false}
  />
  );
  });

diff --git a/static/app/components/events/interfaces/crashContent/index.tsx b/static/app/components/events/interfaces/crashContent/index.tsx
@@ -13,7 +13,6 @@ type Props = Pick<
  | 'event'
  | 'newestFirst'
  | 'groupingCurrentLevel'
- | 'hasHierarchicalGrouping'
 > & {
  exception?: ExceptionType;
  stacktrace?: ExceptionValue['stacktrace'];
@@ -26,7 +25,6 @@ export function CrashContent({
  newestFirst,
  projectSlug,
  groupingCurrentLevel,
- hasHierarchicalGrouping,
  exception,
  stacktrace,
 }: Props) {
@@ -40,7 +38,6 @@ export function CrashContent({
  event={event}
  values={exception.values}
  groupingCurrentLevel={groupingCurrentLevel}
- hasHierarchicalGrouping={hasHierarchicalGrouping}
  />
  );
  }
@@ -56,7 +53,6 @@ export function CrashContent({
  event={event}
  platform={platform}
  groupingCurrentLevel={groupingCurrentLevel}
- hasHierarchicalGrouping={hasHierarchicalGrouping}
  />
  );
  }