Skip to content

Commit

Permalink
drop(grouping): Remove native fuzzing (#76991)
Browse files Browse the repository at this point in the history 
Partially reverts #24346

This feature is only enabled in the mobile grouping config which no SaaS
customer is using and was never shipped to GA.

If we want to, we can always add it back.
  • Loading branch information
@armenzg
armenzg authored Sep 6, 2024
1 parent e4b0907 commit d106a5b
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 32 deletions.
3 changes: 0 additions & 3 deletions src/sentry/grouping/strategies/configurations.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@
# Use the `package` component of a frame as fallback where other
# information would be used but is not available.
"use_package_fallback": False,
# Remove platform differences in native frames
"native_fuzzing": False,
# replaces generated IDs in Java stack frames related to CGLIB and hibernate
"java_cglib_hibernate_logic": False,
},
Expand Down Expand Up @@ -176,7 +174,6 @@ def register_strategy_config(id: str, **kwargs) -> type[StrategyConfiguration]:
"hierarchical_grouping": True,
"discard_native_filename": True,
"use_package_fallback": True,
"native_fuzzing": True,
},
enhancements_base="mobile:2021-04-02",
)
Expand Down
7 changes: 0 additions & 7 deletions src/sentry/grouping/strategies/newstyle.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -288,13 +288,6 @@ def get_function_component(
function_component.update(values=[new_function], hint="isolated function")
func = new_function

if context["native_fuzzing"]:
# Normalize macOS/llvm anonymous namespaces to
# Windows-like/msvc
new_function = func.replace("(anonymous namespace)", "`anonymous namespace'")
if new_function != func:
function_component.update(values=[new_function])

elif context["javascript_fuzzing"] and behavior_family == "javascript":
# This changes Object.foo or Foo.foo into foo so that we can
# resolve some common cross browser differences
Expand Down
44 changes: 22 additions & 22 deletions .../test_variants/test_event_hash_variant/mobile@2021_02_12/native_with_function_name.pysnap
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
created: '2024-09-04T19:48:05.303653+00:00'
created: '2024-09-05T13:32:09.452717+00:00'
creator: sentry
source: tests/sentry/grouping/test_variants.py
---
Expand All @@ -10,7 +10,7 @@ app:
threads (thread has no stacktrace)
--------------------------------------------------------------------------
app-depth-1:
hash: "7b82f61c02dceddacf473738f7827805"
hash: "e002eefcebcc5e920bcddc9c81a06470"
component:
app-depth-1*
exception*
Expand All @@ -19,7 +19,7 @@ app-depth-1:
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::something::nested::Foo<T>::crash"
"(anonymous namespace)::something::nested::Foo<T>::crash"
package (ignored because function takes precedence)
"crash"
type (ignored because exception is synthetic)
Expand All @@ -28,7 +28,7 @@ app-depth-1:
"Fatal Error: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS"
--------------------------------------------------------------------------
app-depth-2:
hash: "ecaeb0c00f2962b1e3e3f40313787711"
hash: "f0a8645562acd4cde0096d53ab69f9ac"
component:
app-depth-2*
exception*
Expand All @@ -37,14 +37,14 @@ app-depth-2:
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::crash"
"(anonymous namespace)::crash"
package (ignored because function takes precedence)
"crash"
frame*
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::something::nested::Foo<T>::crash"
"(anonymous namespace)::something::nested::Foo<T>::crash"
package (ignored because function takes precedence)
"crash"
type (ignored because exception is synthetic)
Expand All @@ -53,7 +53,7 @@ app-depth-2:
"Fatal Error: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS"
--------------------------------------------------------------------------
app-depth-3:
hash: "d64904dcba276f8cad4f718cda9d8690"
hash: "102ff7b3fc873a8b1728ddbdffbaab81"
component:
app-depth-3*
exception*
Expand All @@ -62,21 +62,21 @@ app-depth-3:
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::start"
"(anonymous namespace)::start"
package (ignored because function takes precedence)
"crash"
frame*
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::crash"
"(anonymous namespace)::crash"
package (ignored because function takes precedence)
"crash"
frame*
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::something::nested::Foo<T>::crash"
"(anonymous namespace)::something::nested::Foo<T>::crash"
package (ignored because function takes precedence)
"crash"
type (ignored because exception is synthetic)
Expand All @@ -85,7 +85,7 @@ app-depth-3:
"Fatal Error: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS"
--------------------------------------------------------------------------
app-depth-4:
hash: "a07df792479c5ba46fc056236749b796"
hash: "3b9ea09c02c81c1c6e5884c1fadcdda0"
component:
app-depth-4*
exception*
Expand All @@ -101,21 +101,21 @@ app-depth-4:
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::start"
"(anonymous namespace)::start"
package (ignored because function takes precedence)
"crash"
frame*
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::crash"
"(anonymous namespace)::crash"
package (ignored because function takes precedence)
"crash"
frame*
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::something::nested::Foo<T>::crash"
"(anonymous namespace)::something::nested::Foo<T>::crash"
package (ignored because function takes precedence)
"crash"
type (ignored because exception is synthetic)
Expand All @@ -124,7 +124,7 @@ app-depth-4:
"Fatal Error: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS"
--------------------------------------------------------------------------
app-depth-max:
hash: "a07df792479c5ba46fc056236749b796"
hash: "3b9ea09c02c81c1c6e5884c1fadcdda0"
component:
app-depth-max*
exception*
Expand All @@ -140,21 +140,21 @@ app-depth-max:
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::start"
"(anonymous namespace)::start"
package (ignored because function takes precedence)
"crash"
frame*
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::crash"
"(anonymous namespace)::crash"
package (ignored because function takes precedence)
"crash"
frame*
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::something::nested::Foo<T>::crash"
"(anonymous namespace)::something::nested::Foo<T>::crash"
package (ignored because function takes precedence)
"crash"
type (ignored because exception is synthetic)
Expand All @@ -163,7 +163,7 @@ app-depth-max:
"Fatal Error: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS"
--------------------------------------------------------------------------
system:
hash: "a07df792479c5ba46fc056236749b796"
hash: "3b9ea09c02c81c1c6e5884c1fadcdda0"
component:
system*
exception*
Expand All @@ -179,21 +179,21 @@ system:
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::start"
"(anonymous namespace)::start"
package (ignored because function takes precedence)
"crash"
frame*
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::crash"
"(anonymous namespace)::crash"
package (ignored because function takes precedence)
"crash"
frame*
filename (discarded native filename for grouping stability)
"main.cpp"
function*
"`anonymous namespace'::something::nested::Foo<T>::crash"
"(anonymous namespace)::something::nested::Foo<T>::crash"
package (ignored because function takes precedence)
"crash"
type (ignored because exception is synthetic)
Expand Down

0 comments on commit d106a5b

Please sign in to comment.