typing(api): Type check src/sentry/api/endpoints/project_group_index.…

…py (#76667)
getsentry · Aug 28, 2024 · e4ff0e6 · e4ff0e6
1 parent 7225d3a
commit e4ff0e6
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -167,7 +167,6 @@ module = [
     "sentry.api.endpoints.organization_sessions",
     "sentry.api.endpoints.organization_stats",
     "sentry.api.endpoints.organization_teams",
-    "sentry.api.endpoints.project_group_index",
     "sentry.api.endpoints.project_index",
     "sentry.api.endpoints.project_ownership",
     "sentry.api.endpoints.project_release_files",

diff --git a/src/sentry/api/endpoints/project_group_index.py b/src/sentry/api/endpoints/project_group_index.py
@@ -114,7 +114,7 @@ def get(self, request: Request, project) -> Response:
                     matching_event = eventstore.backend.get_event_by_id(project.id, event_id)
             elif matching_group is None:
                 matching_group = get_by_short_id(
-                    project.organization_id, request.GET.get("shortIdLookup"), query
+                    project.organization_id, request.GET.get("shortIdLookup", "0"), query
                 )
                 if matching_group is not None and matching_group.project_id != project.id:
                     matching_group = None

diff --git a/src/sentry/api/helpers/group_index/index.py b/src/sentry/api/helpers/group_index/index.py
@@ -1,6 +1,6 @@
 from collections.abc import Callable, Mapping, MutableMapping, Sequence
 from datetime import datetime
-from typing import Any, Optional
+from typing import Any
 
 import sentry_sdk
 from django.contrib.auth.models import AnonymousUser
@@ -184,7 +184,7 @@ def get_by_short_id(
     organization_id: int,
     is_short_id_lookup: str,
     query: str,
-) -> Optional["Group"]:
+) -> Group | None:
     if is_short_id_lookup == "1" and looks_like_short_id(query):
         try:
             return Group.objects.by_qualified_short_id(organization_id, query)

diff --git a/src/sentry/api/helpers/group_index/update.py b/src/sentry/api/helpers/group_index/update.py
@@ -165,7 +165,7 @@ def get_current_release_version_of_group(
 
 def update_groups(
     request: Request,
-    group_ids: Sequence[int] | None,
+    group_ids: Sequence[int | str] | None,
     projects: Sequence[Project],
     organization_id: int,
     search_fn: SearchFunction | None,