Revert "feat(onboarding) add profiling to onboarding docs (#75273)"

This reverts commit 06e367b. Co-authored-by: JonasBa <9317857+JonasBa@users.noreply.github.com>
getsentry · Aug 1, 2024 · e870d41 · e870d41
1 parent 8dceff3
commit e870d41
Show file tree

Hide file tree

Showing 10 changed files with 48 additions and 100 deletions.
diff --git a/static/app/components/onboarding/gettingStartedDoc/utils/profilingOnboarding.tsx b/static/app/components/onboarding/gettingStartedDoc/utils/profilingOnboarding.tsx
diff --git a/static/app/components/onboarding/productSelection.tsx b/static/app/components/onboarding/productSelection.tsx
@@ -116,37 +116,30 @@ export const platformProductAvailability = {
  javascript: [ProductSolution.PERFORMANCE_MONITORING, ProductSolution.SESSION_REPLAY],
  'javascript-react': [
  ProductSolution.PERFORMANCE_MONITORING,
- ProductSolution.PROFILING,
  ProductSolution.SESSION_REPLAY,
  ],
  'javascript-vue': [
  ProductSolution.PERFORMANCE_MONITORING,
- ProductSolution.PROFILING,
  ProductSolution.SESSION_REPLAY,
  ],
  'javascript-angular': [
  ProductSolution.PERFORMANCE_MONITORING,
- ProductSolution.PROFILING,
  ProductSolution.SESSION_REPLAY,
  ],
  'javascript-ember': [
  ProductSolution.PERFORMANCE_MONITORING,
- ProductSolution.PROFILING,
  ProductSolution.SESSION_REPLAY,
  ],
  'javascript-gatsby': [
  ProductSolution.PERFORMANCE_MONITORING,
- ProductSolution.PROFILING,
  ProductSolution.SESSION_REPLAY,
  ],
  'javascript-solid': [
  ProductSolution.PERFORMANCE_MONITORING,
- ProductSolution.PROFILING,
  ProductSolution.SESSION_REPLAY,
  ],
  'javascript-svelte': [
  ProductSolution.PERFORMANCE_MONITORING,
- ProductSolution.PROFILING,
  ProductSolution.SESSION_REPLAY,
  ],
  'javascript-astro': [

diff --git a/static/app/gettingStartedDocs/javascript/angular.tsx b/static/app/gettingStartedDocs/javascript/angular.tsx
@@ -16,7 +16,6 @@ import {
  getFeedbackConfigureDescription,
 } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding';
 import {getJSMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding';
-import {getProfilingDocumentHeaderConfigurationStep} from 'sentry/components/onboarding/gettingStartedDoc/utils/profilingOnboarding';
 import {
  getReplayConfigOptions,
  getReplayConfigureDescription,
@@ -47,10 +46,6 @@ const getNextStep = (
  step => step.id !== ProductSolution.SESSION_REPLAY
  );
  }
-
- if (params.isProfilingSelected) {
- nextStepDocs = nextStepDocs.filter(step => step.id !== ProductSolution.PROFILING);
- }
  return nextStepDocs;
 };
 
@@ -138,9 +133,6 @@ const onboarding: OnboardingConfig = {
  },
  ],
  },
- ...(params.isProfilingSelected
- ? [getProfilingDocumentHeaderConfigurationStep()]
- : []),
  getUploadSourceMapsStep({
  guideLink: 'https://docs.sentry.io/platforms/javascript/guides/angular/sourcemaps/',
  ...params,
@@ -195,7 +187,6 @@ function getSdkSetupSnippet(params: Params) {
  import * as Sentry from "@sentry/angular";
 
  import { AppModule } from "./app/app.module";
-import { getProfilingDocumentHeaderConfigurationStep } from '../../components/onboarding/gettingStartedDoc/utils/profilingOnboarding';
 
  Sentry.init({
  dsn: "${params.dsn}",
@@ -241,8 +232,12 @@ ${getFeedbackConfigOptions(params.feedbackOptions)}}),`
  }${
  params.isProfilingSelected
  ? `
- // Profiling
- profilesSampleRate: 1.0, // Profile 100% of the transactions. This value is relative to tracesSampleRate`
+ // Set profilesSampleRate to 1.0 to profile every transaction.
+ // Since profilesSampleRate is relative to tracesSampleRate,
+ // the final profiling rate can be computed as tracesSampleRate * profilesSampleRate
+ // For example, a tracesSampleRate of 0.5 and profilesSampleRate of 0.5 would
+ // results in 25% of transactions being profiled (0.5*0.5=0.25)
+ profilesSampleRate: 1.0,`
  : ''
  }
  });`;

diff --git a/static/app/gettingStartedDocs/javascript/ember.tsx b/static/app/gettingStartedDocs/javascript/ember.tsx
@@ -16,7 +16,6 @@ import {
  getFeedbackConfigureDescription,
 } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding';
 import {getJSMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding';
-import {getProfilingDocumentHeaderConfigurationStep} from 'sentry/components/onboarding/gettingStartedDoc/utils/profilingOnboarding';
 import {
  getReplayConfigOptions,
  getReplayConfigureDescription,
@@ -32,7 +31,6 @@ import loadInitializers from "ember-load-initializers";
 import config from "./config/environment";
 
 import * as Sentry from "@sentry/ember";
-import { getProfilingDocumentHeaderConfigurationStep } from 'sentry/components/onboarding/gettingStartedDoc/utils/profilingOnboarding';
 
 Sentry.init({
  dsn: "${params.dsn}",
@@ -73,8 +71,12 @@ ${getFeedbackConfigOptions(params.feedbackOptions)}}),`
 }${
  params.isProfilingSelected
  ? `
- // Profiling
- profilesSampleRate: 1.0, // Profile 100% of the transactions. This value is relative to tracesSampleRate`
+ // Set profilesSampleRate to 1.0 to profile every transaction.
+ // Since profilesSampleRate is relative to tracesSampleRate,
+ // the final profiling rate can be computed as tracesSampleRate * profilesSampleRate
+ // For example, a tracesSampleRate of 0.5 and profilesSampleRate of 0.5 would
+ // results in 25% of transactions being profiled (0.5*0.5=0.25)
+ profilesSampleRate: 1.0,`
  : ''
 }
 });
@@ -132,9 +134,6 @@ const onboarding: OnboardingConfig = {
  },
  ],
  },
- ...(params.isProfilingSelected
- ? [getProfilingDocumentHeaderConfigurationStep()]
- : []),
  getUploadSourceMapsStep({
  guideLink: 'https://docs.sentry.io/platforms/javascript/guides/ember/sourcemaps/',
  }),

diff --git a/static/app/gettingStartedDocs/javascript/gatsby.tsx b/static/app/gettingStartedDocs/javascript/gatsby.tsx
@@ -18,7 +18,6 @@ import {
  getFeedbackConfigureDescription,
 } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding';
 import {getJSMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding';
-import {getProfilingDocumentHeaderConfigurationStep} from 'sentry/components/onboarding/gettingStartedDoc/utils/profilingOnboarding';
 import {
  getReplayConfigOptions,
  getReplayConfigureDescription,
@@ -29,7 +28,6 @@ type Params = DocsParams;
 
 const getSdkSetupSnippet = (params: Params) => `
 import * as Sentry from "@sentry/gatsby";
-import { getProfilingDocumentHeaderConfigurationStep } from 'sentry/components/onboarding/gettingStartedDoc/utils/profilingOnboarding';
 
 Sentry.init({
  dsn: "${params.dsn}",
@@ -75,8 +73,12 @@ ${getFeedbackConfigOptions(params.feedbackOptions)}}),`
 }${
  params.isProfilingSelected
  ? `
- // Profiling
- profilesSampleRate: 1.0, // Profile 100% of the transactions. This value is relative to tracesSampleRate`
+ // Set profilesSampleRate to 1.0 to profile every transaction.
+ // Since profilesSampleRate is relative to tracesSampleRate,
+ // the final profiling rate can be computed as tracesSampleRate * profilesSampleRate
+ // For example, a tracesSampleRate of 0.5 and profilesSampleRate of 0.5 would
+ // results in 25% of transactions being profiled (0.5*0.5=0.25)
+ profilesSampleRate: 1.0,`
  : ''
 }
 });
@@ -164,9 +166,6 @@ const onboarding: OnboardingConfig = {
  ],
  configure: (params: Params) => [
  getConfigureStep(params),
- ...(params.isProfilingSelected
- ? [getProfilingDocumentHeaderConfigurationStep()]
- : []),
  getUploadSourceMapsStep({
  guideLink: 'https://docs.sentry.io/platforms/javascript/guides/gatsby/sourcemaps//',
  }),

diff --git a/static/app/gettingStartedDocs/javascript/javascript.tsx b/static/app/gettingStartedDocs/javascript/javascript.tsx
@@ -16,7 +16,6 @@ import {
  getFeedbackConfigureDescription,
 } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding';
 import {getJSMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding';
-import {getProfilingDocumentHeaderConfigurationStep} from 'sentry/components/onboarding/gettingStartedDoc/utils/profilingOnboarding';
 import {
  getReplayConfigOptions,
  getReplayConfigureDescription,
@@ -73,8 +72,12 @@ ${getFeedbackConfigOptions(params.feedbackOptions)}}),`
 }${
  params.isProfilingSelected
  ? `
- // Profiling
- profilesSampleRate: 1.0, // Profile 100% of the transactions. This value is relative to tracesSampleRate`
+ // Set profilesSampleRate to 1.0 to profile every transaction.
+ // Since profilesSampleRate is relative to tracesSampleRate,
+ // the final profiling rate can be computed as tracesSampleRate * profilesSampleRate
+ // For example, a tracesSampleRate of 0.5 and profilesSampleRate of 0.5 would
+ // results in 25% of transactions being profiled (0.5*0.5=0.25)
+ profilesSampleRate: 1.0,`
  : ''
 }
 });
@@ -132,9 +135,6 @@ const onboarding: OnboardingConfig = {
  },
  ],
  },
- ...(params.isProfilingSelected
- ? [getProfilingDocumentHeaderConfigurationStep()]
- : []),
  getUploadSourceMapsStep({
  guideLink: 'https://docs.sentry.io/platforms/javascript/sourcemaps/',
  }),

diff --git a/static/app/gettingStartedDocs/javascript/react.tsx b/static/app/gettingStartedDocs/javascript/react.tsx
@@ -16,7 +16,6 @@ import {
  getFeedbackConfigureDescription,
 } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding';
 import {getJSMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding';
-import {getProfilingDocumentHeaderConfigurationStep} from 'sentry/components/onboarding/gettingStartedDoc/utils/profilingOnboarding';
 import {
  getReplayConfigOptions,
  getReplayConfigureDescription,
@@ -66,8 +65,12 @@ ${getFeedbackConfigOptions(params.feedbackOptions)}}),`
 }${
  params.isProfilingSelected
  ? `
- // Profiling
- profilesSampleRate: 1.0, // Profile 100% of the transactions. This value is relative to tracesSampleRate`
+ // Set profilesSampleRate to 1.0 to profile every transaction.
+ // Since profilesSampleRate is relative to tracesSampleRate,
+ // the final profiling rate can be computed as tracesSampleRate * profilesSampleRate
+ // For example, a tracesSampleRate of 0.5 and profilesSampleRate of 0.5 would
+ // results in 25% of transactions being profiled (0.5*0.5=0.25)
+ profilesSampleRate: 1.0,`
  : ''
 }${
  params.isReplaySelected
@@ -141,9 +144,6 @@ const onboarding: OnboardingConfig = {
  },
  ],
  },
- ...(params.isProfilingSelected
- ? [getProfilingDocumentHeaderConfigurationStep()]
- : []),
  getUploadSourceMapsStep({
  guideLink: 'https://docs.sentry.io/platforms/javascript/guides/react/sourcemaps/',
  }),

diff --git a/static/app/gettingStartedDocs/javascript/solid.tsx b/static/app/gettingStartedDocs/javascript/solid.tsx
@@ -16,7 +16,6 @@ import {
  getFeedbackConfigureDescription,
 } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding';
 import {getJSMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding';
-import {getProfilingDocumentHeaderConfigurationStep} from 'sentry/components/onboarding/gettingStartedDoc/utils/profilingOnboarding';
 import {
  getReplayConfigOptions,
  getReplayConfigureDescription,
@@ -74,8 +73,12 @@ ${getFeedbackConfigOptions(params.feedbackOptions)}}),`
 }${
  params.isProfilingSelected
  ? `
- // Profiling
- profilesSampleRate: 1.0, // Profile 100% of the transactions. This value is relative to tracesSampleRate`
+ // Set profilesSampleRate to 1.0 to profile every transaction.
+ // Since profilesSampleRate is relative to tracesSampleRate,
+ // the final profiling rate can be computed as tracesSampleRate * profilesSampleRate
+ // For example, a tracesSampleRate of 0.5 and profilesSampleRate of 0.5 would
+ // results in 25% of transactions being profiled (0.5*0.5=0.25)
+ profilesSampleRate: 1.0,`
  : ''
 }
 });
@@ -151,9 +154,6 @@ const onboarding: OnboardingConfig = {
  },
  ],
  },
- ...(params.isProfilingSelected
- ? [getProfilingDocumentHeaderConfigurationStep()]
- : []),
  getUploadSourceMapsStep({
  guideLink: 'https://docs.sentry.io/platforms/javascript/guides/solid/sourcemaps/',
  }),

diff --git a/static/app/gettingStartedDocs/javascript/svelte.tsx b/static/app/gettingStartedDocs/javascript/svelte.tsx
@@ -16,7 +16,6 @@ import {
  getFeedbackConfigureDescription,
 } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding';
 import {getJSMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding';
-import {getProfilingDocumentHeaderConfigurationStep} from 'sentry/components/onboarding/gettingStartedDoc/utils/profilingOnboarding';
 import {
  getReplayConfigOptions,
  getReplayConfigureDescription,
@@ -75,8 +74,12 @@ ${getFeedbackConfigOptions(params.feedbackOptions)}}),`
 }${
  params.isProfilingSelected
  ? `
- // Profiling
- profilesSampleRate: 1.0, // Profile 100% of the transactions. This value is relative to tracesSampleRate`
+ // Set profilesSampleRate to 1.0 to profile every transaction.
+ // Since profilesSampleRate is relative to tracesSampleRate,
+ // the final profiling rate can be computed as tracesSampleRate * profilesSampleRate
+ // For example, a tracesSampleRate of 0.5 and profilesSampleRate of 0.5 would
+ // results in 25% of transactions being profiled (0.5*0.5=0.25)
+ profilesSampleRate: 1.0,`
  : ''
 }
 });
@@ -146,9 +149,6 @@ const onboarding: OnboardingConfig = {
  },
  ],
  },
- ...(params.isProfilingSelected
- ? [getProfilingDocumentHeaderConfigurationStep()]
- : []),
  getUploadSourceMapsStep({
  guideLink: 'https://docs.sentry.io/platforms/javascript/guides/svelte/sourcemaps/',
  }),

diff --git a/static/app/gettingStartedDocs/javascript/vue.tsx b/static/app/gettingStartedDocs/javascript/vue.tsx
@@ -17,7 +17,6 @@ import {
  getFeedbackSDKSetupSnippet,
 } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding';
 import {getJSMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding';
-import {getProfilingDocumentHeaderConfigurationStep} from 'sentry/components/onboarding/gettingStartedDoc/utils/profilingOnboarding';
 import {
  getReplayConfigOptions,
  getReplayConfigureDescription,
@@ -89,8 +88,12 @@ const getSentryInitLayout = (params: Params, siblingOption: string): string => {
  }${
  params.isProfilingSelected
  ? `
- // Profiling
- profilesSampleRate: 1.0, // Profile 100% of the transactions. This value is relative to tracesSampleRate`
+ // Set profilesSampleRate to 1.0 to profile every transaction.
+ // Since profilesSampleRate is relative to tracesSampleRate,
+ // the final profiling rate can be computed as tracesSampleRate * profilesSampleRate
+ // For example, a tracesSampleRate of 0.5 and profilesSampleRate of 0.5 would
+ // results in 25% of transactions being profiled (0.5*0.5=0.25)
+ profilesSampleRate: 1.0,`
  : ''
  }
  });`;
@@ -166,9 +169,6 @@ const onboarding: OnboardingConfig<PlatformOptions> = {
  ),
  configurations: getSetupConfiguration(params),
  },
- ...(params.isProfilingSelected
- ? [getProfilingDocumentHeaderConfigurationStep()]
- : []),
  getUploadSourceMapsStep({
  guideLink: 'https://docs.sentry.io/platforms/javascript/guides/vue/sourcemaps/',
  ...params,