New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack trace: Remove "System" frame tags #50693

Closed

Tracked by

malwilley opened this issue Jun 9, 2023 · 1 comment · Fixed by #51758

Milestone

Native Stack Trac...

Member

malwilley commented Jun 9, 2023 •

edited by 17hogeju

Loading

We want to remove this label because:

"System" as a label doesn't always correctly describe the frame
Since there are only two types of frames, the absence of an "In App" frame confers the same meaning
We will have a better way to distinguish the two frame types after Stack trace: Use gray and italicized text for system frames #50691 is completed

malwilley mentioned this issue

[Epic] Native stack trace improvements #50690

Open

malwilley assigned 17hogeju and unassigned 17hogeju

malwilley added this to the Native Stack Trace UX Improvements milestone

17hogeju mentioned this issue

Use gray and italicized text for system frames #51758

Merged

Contributor

17hogeju commented Jul 10, 2023

With 6 responses to Feedback on proposed stack trace changes, people seem to be mostly for gray/italicizing and removing the system tag

malwilley linked a pull request

that will close this issue

Use gray and italicized text for system frames #51758

Merged

17hogeju closed this as completed in #51758

17hogeju pushed a commit that referenced this issue


Use gray and italicized text for system frames (#51758)

25f0725

Closes #50691 and
#50693

Distinguishes "In App" and "System" frames using gray/italicized text
with no pill for "System".

<img width="1125" alt="Screenshot 2023-07-17 at 4 01 52 PM"
src="https://github.com/getsentry/sentry/assets/22582037/1c6d31df-4b7c-4748-ac36-764fac744987">
<img width="1125" alt="Screenshot 2023-07-17 at 4 01 40 PM"
src="https://github.com/getsentry/sentry/assets/22582037/64efc0ec-5d86-4baf-8887-8f0c80a1a7ca">


### Non-Native stacktrace changes

![Screenshot 2023-06-29 at 10 17 37
AM](https://github.com/getsentry/sentry/assets/22582037/2a76e609-3fc5-489d-af81-8ef1b726d062)
![Screenshot 2023-06-29 at 10 16 38
AM](https://github.com/getsentry/sentry/assets/22582037/417fffd4-3402-4171-91b2-5883ec3ecc50)

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.