-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gray and italicized text for system frames #51758
Conversation
@17hogeju ah good catch. We do want to fix that before merging. This is happending because the containing element has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to put this behind a feature flag, requesting changes so we don't accidentally merge
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
This reverts commit 2689d14.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51758 +/- ##
=======================================
Coverage 79.45% 79.45%
=======================================
Files 4936 4936
Lines 207367 207379 +12
Branches 35426 35426
=======================================
+ Hits 164756 164773 +17
+ Misses 37572 37568 -4
+ Partials 5039 5038 -1
|
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Closes #50691 and #50693
Distinguishes "In App" and "System" frames using gray/italicized text with no pill for "System".
Non-Native stacktrace changes