Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user_details.py / UserDetailsEndpoint.put() gets email from wrong request field #77000

Open
nvsmirnov opened this issue Sep 5, 2024 · 5 comments

Comments

@nvsmirnov
Copy link

nvsmirnov commented Sep 5, 2024

Environment

self-hosted (https://develop.sentry.dev/self-hosted/)

Steps to Reproduce

  1. Have user names which are different from email addresses (i.e. username is "john", email is "john@smith.tld").
  2. Go to Admin/Users/User (pick the user which has verified email)
  3. Make some change (for example, switch Admin status)
  4. Click "Save Changes".

Expected Result

There should be no error while saving changes in this case.

Actual Result

Getting HTTP 400 {"detail": "Verified email address is not found."} despite the fact email is verified.

Simple patch solves the problem, PR: #77012

Product Area

Other

Link

No response

DSN

No response

Version

24.8.0

@getsantry
Copy link
Contributor

getsantry bot commented Sep 5, 2024

Auto-routing to @getsentry/product-owners-issues for triage ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Sep 5, 2024

Routing to @getsentry/product-owners-apis for triage ⏲️

nvsmirnov added a commit to nvsmirnov/sentry-issue-77000 that referenced this issue Sep 5, 2024
@leedongwei
Copy link
Member

Thanks for the PR! I'll have someone review it and add tests to prevent a regression.

@lucas-cantelli
Copy link

We just replaced the username by the email and saved the changes as a workaround for this. Still, would love to have this fixed though.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Oct 30, 2024
@sentaur-athena
Copy link
Member

Sure. will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

5 participants