Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue-77000 #77012

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix for issue-77000 #77012

wants to merge 3 commits into from

Conversation

nvsmirnov
Copy link

This PR fixes bug #77000

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 5, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Sep 27, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Sep 27, 2024
@nvsmirnov
Copy link
Author

up

@getsantry getsantry bot removed the Stale label Sep 28, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Oct 20, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 20, 2024
@nvsmirnov
Copy link
Author

this is still relevant PR

@getsantry getsantry bot removed the Stale label Oct 21, 2024
@sentaur-athena sentaur-athena added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Oct 31, 2024
@sentaur-athena
Copy link
Member

The fix looks good to me but it seems like there are failing tests that need to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants