-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(referrer-tagstore): fix tagstore #50241
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50241 +/- ##
==========================================
+ Coverage 79.89% 81.10% +1.20%
==========================================
Files 5027 4842 -185
Lines 213862 203184 -10678
Branches 36379 11269 -25110
==========================================
- Hits 170861 164783 -6078
- Misses 37761 38152 +391
+ Partials 5240 249 -4991
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
/gcbrun |
/gcbrun |
thanks! |
getsentry/self-hosted#2349
I'm using self-hosted sentry version 23.3.1 and getting the following traceback in console logs when I try to get any particular tag (e.g. >>> get('https://{sentry}/api/0/projects/{org}/{project}/tags/release/')). Seems second underscore was missed here https://github.com/getsentry/sentry/blob/master/src/sentry/snuba/referrer.py#L557
I patched referrer.py locally and now it looks good.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.