Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(referrer-tagstore): fix tagstore #50241

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

RedShiba
Copy link
Contributor

@RedShiba RedShiba commented Jun 2, 2023

getsentry/self-hosted#2349
I'm using self-hosted sentry version 23.3.1 and getting the following traceback in console logs when I try to get any particular tag (e.g. >>> get('https://{sentry}/api/0/projects/{org}/{project}/tags/release/')). Seems second underscore was missed here https://github.com/getsentry/sentry/blob/master/src/sentry/snuba/referrer.py#L557

sentry-web                                  | Traceback (most recent call last):
sentry-web                                  |   File "/usr/local/lib/python3.8/site-packages/sentry/snuba/referrer.py", line 597, in validate_referrer
sentry-web                                  |     raise Exception(error_message)
sentry-web                                  | Exception: referrer tagstore.__get_tag_key_and_top_values is not part of Referrer Enum

I patched referrer.py locally and now it looks good.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #50241 (c5f7f07) into master (4ed1618) will increase coverage by 1.20%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head c5f7f07 differs from pull request most recent head 1e5c7d5. Consider uploading reports for the commit 1e5c7d5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #50241      +/-   ##
==========================================
+ Coverage   79.89%   81.10%   +1.20%     
==========================================
  Files        5027     4842     -185     
  Lines      213862   203184   -10678     
  Branches    36379    11269   -25110     
==========================================
- Hits       170861   164783    -6078     
- Misses      37761    38152     +391     
+ Partials     5240      249    -4991     
Files Changed Coverage Δ
src/sentry/snuba/referrer.py 100.00% <100.00%> (ø)

... and 2485 files with indirect coverage changes

@github-actions
Copy link
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@hubertdeng123
Copy link
Member

/gcbrun

@hubertdeng123 hubertdeng123 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Aug 17, 2023
@hubertdeng123 hubertdeng123 enabled auto-merge (squash) August 17, 2023 00:45
@hubertdeng123
Copy link
Member

/gcbrun

@hubertdeng123 hubertdeng123 merged commit 08b18dd into getsentry:master Aug 17, 2023
63 of 64 checks passed
@RedShiba
Copy link
Contributor Author

thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants