Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(crons): Remove crons issue platform flag #51291

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

rjo100
Copy link
Contributor

@rjo100 rjo100 commented Jun 20, 2023

Removes flag as feature is live in production

@rjo100 rjo100 requested a review from a team as a code owner June 20, 2023 17:37
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #51291 (3df2709) into master (cd475eb) will increase coverage by 0.64%.
The diff coverage is 93.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #51291      +/-   ##
==========================================
+ Coverage   80.57%   81.22%   +0.64%     
==========================================
  Files        4891     4893       +2     
  Lines      205011   205040      +29     
  Branches    11107    11107              
==========================================
+ Hits       165186   166534    +1348     
+ Misses      39579    38260    -1319     
  Partials      246      246              
Impacted Files Coverage Δ
src/sentry/conf/server.py 91.63% <ø> (ø)
src/sentry/monitors/models.py 94.29% <ø> (ø)
static/app/views/alerts/rules/issue/index.tsx 76.09% <ø> (ø)
src/sentry/integrations/discord/integration.py 90.47% <90.47%> (ø)
src/sentry/monitors/consumers/monitor_consumer.py 92.25% <92.85%> (-3.93%) ⬇️
src/sentry/features/__init__.py 100.00% <100.00%> (ø)
src/sentry/integrations/discord/__init__.py 100.00% <100.00%> (ø)
...nitors/endpoints/monitor_ingest_checkin_details.py 90.90% <100.00%> (+0.52%) ⬆️
src/sentry/monitors/utils.py 98.24% <100.00%> (+0.20%) ⬆️
src/sentry/monitors/validators.py 95.45% <100.00%> (ø)

... and 88 files with indirect coverage changes

@rjo100 rjo100 merged commit 6a91676 into master Jun 30, 2023
@rjo100 rjo100 deleted the rjo100/initial-cron-legacy-removal branch June 30, 2023 18:34
@rjo100 rjo100 added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jun 30, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: a1226f9

getsentry-bot added a commit that referenced this pull request Jun 30, 2023
This reverts commit 6a91676.

Co-authored-by: rjo100 <7078270+rjo100@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants