Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hybrid-cloud): Implement proxy client for MsTeams #51419

Merged
merged 9 commits into from
Jun 22, 2023
Merged

feat(hybrid-cloud): Implement proxy client for MsTeams #51419

merged 9 commits into from
Jun 22, 2023

Conversation

dashed
Copy link
Member

@dashed dashed commented Jun 21, 2023

Update the MsTeamsClient API client to extend IntegrationProxyClient.

@dashed dashed requested a review from a team June 21, 2023 23:12
@dashed dashed self-assigned this Jun 21, 2023
@dashed dashed requested a review from a team as a code owner June 21, 2023 23:12
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #51419 (4992435) into master (bd67990) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #51419      +/-   ##
==========================================
- Coverage   81.24%   81.24%   -0.01%     
==========================================
  Files        4896     4896              
  Lines      205370   205385      +15     
  Branches    11102    11102              
==========================================
+ Hits       166858   166866       +8     
- Misses      38266    38273       +7     
  Partials      246      246
Impacted Files Coverage Δ
src/sentry/integrations/msteams/client.py 100.00% <100.00%> (+1.06%) ⬆️

... and 3 files with indirect coverage changes

markstory
markstory approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dashed dashed merged commit f15d3b3 into master Jun 22, 2023
@dashed dashed deleted the hybrid-cloud/msteams/1-proxy-client branch June 22, 2023 20:49
@scttcper scttcper added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jun 22, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: ccc7a03

getsentry-bot added a commit that referenced this pull request Jun 22, 2023
@getsentry-bot @scttcper
Revert "feat(hybrid-cloud): Implement proxy client for MsTeams (#51419)"
ccc7a03 
This reverts commit f15d3b3.

Co-authored-by: scttcper <1400464+scttcper@users.noreply.github.com>
@dashed dashed mentioned this pull request Jun 26, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markstory markstory markstory approved these changes

Assignees

@dashed dashed

Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dashed @getsentry-bot @markstory @scttcper