Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimental(on-demand-metrics): Implement transpiler for rules generation #51868

Closed
wants to merge 2 commits into from
Closed

experimental(on-demand-metrics): Implement transpiler for rules generation #51868

wants to merge 2 commits into from

Conversation

iambriccardo
Copy link
Member

  • feat(metrics): Implement transpiler for Relay rules
  • Implement simple parsing

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 29, 2023
@iambriccardo iambriccardo changed the title riccardo/feat/metrics transpiler experimental(on-demand-metrics): Implement transpiler for rules generation Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #51868 (399057b) into master (76f945b) will increase coverage by 0.06%.
The diff coverage is 87.32%.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #51868     +/-   ##
=========================================
+ Coverage    81.25    81.31   +0.06     
=========================================
  Files        4896     4903      +7     
  Lines      205353   206254    +901     
  Branches    11101    11101             
=========================================
+ Hits       166840   167712    +872     
- Misses      38267    38296     +29     
  Partials      246      246
Impacted Files Coverage Δ
src/sentry/snuba/on_demand_metrics/transpiler.py 87.32% <87.32%> (ø)

... and 354 files with indirect coverage changes

@iambriccardo iambriccardo added the Do Not Merge Don't merge label Jul 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
@asottile-sentry asottile-sentry deleted the riccardo/feat/metrics-transpiler branch December 27, 2023 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Do Not Merge Don't merge Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iambriccardo