Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): Use bulk_reverse_reslove in metrics #52007

Closed
wants to merge 13 commits into from
Closed

feat(metrics): Use bulk_reverse_reslove in metrics #52007

wants to merge 13 commits into from

Conversation

RaduW
Copy link
Contributor

@RaduW RaduW commented Jun 30, 2023 •
edited
Loading

This PR uses bulk_reverse_reslove to avoid N+1 query problems.

Will rebase once PR #51791 is merged.
fixes: #51227

@RaduW RaduW requested a review from a team as a code owner June 30, 2023 15:04
@RaduW RaduW requested a review from a team June 30, 2023 15:04
@RaduW RaduW requested a review from a team as a code owner June 30, 2023 15:04
@RaduW RaduW marked this pull request as draft June 30, 2023 15:04
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Merging #52007 (ec2c591) into master (1806c18) will increase coverage by 0.00%.
The diff coverage is 90.90%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #52007   +/-   ##
=======================================
  Coverage   79.32%   79.32%           
=======================================
  Files        4901     4901           
  Lines      205110   205137   +27     
  Branches    35063    35070    +7     
=======================================
+ Hits       162695   162718   +23     
  Misses      37456    37456           
- Partials     4959     4963    +4
Impacted Files Coverage Δ
src/sentry/sentry_metrics/utils.py 87.01% <77.77%> (-2.99%) ⬇️
...ry/api/endpoints/organization_measurements_meta.py 90.47% <100.00%> (ø)
...c/sentry/release_health/release_monitor/metrics.py 85.91% <100.00%> (+1.06%) ⬆️
src/sentry/snuba/metrics/datasource.py 95.95% <100.00%> (+0.05%) ⬆️
src/sentry/utils/pytest/metrics.py 86.11% <100.00%> (+0.19%) ⬆️

... and 3 files with indirect coverage changes

@RaduW RaduW mentioned this pull request Jul 4, 2023
Merged
@RaduW
Copy link
Contributor Author

RaduW commented Jul 4, 2023 •
edited
Loading

Created a new cleaned PR branched from merge #52115

@RaduW RaduW closed this Jul 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use bulk_reverse_resolve in metrics layer
1 participant
@RaduW