Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sourcemaps): Remove feature flag for artifact bundles UI #52102

Merged
merged 2 commits into from
Jul 4, 2023
Merged

feat(sourcemaps): Remove feature flag for artifact bundles UI #52102

merged 2 commits into from
Jul 4, 2023

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Jul 3, 2023 •
edited
Loading

This PR removes the feature flag used to control whether the artifact bundles UI was shown.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 3, 2023
@iambriccardo iambriccardo requested a review from lforst July 3, 2023 14:47
@iambriccardo iambriccardo marked this pull request as ready for review July 3, 2023 14:47
@iambriccardo iambriccardo added the Do Not Merge Don't merge label Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

Merging #52102 (ed20583) into master (1653ff8) will increase coverage by 2.16%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #52102      +/-   ##
==========================================
+ Coverage   77.16%   79.32%   +2.16%     
==========================================
  Files        4901     4901              
  Lines      205077   205149      +72     
  Branches    35055    35073      +18     
==========================================
+ Hits       158242   162732    +4490     
+ Misses      41937    37456    -4481     
- Partials     4898     4961      +63
Impacted Files Coverage Δ
src/sentry/conf/server.py 91.84% <ø> (+0.01%) ⬆️
src/sentry/features/__init__.py 100.00% <ø> (ø)

... and 301 files with indirect coverage changes

@priscilawebdev priscilawebdev mentioned this pull request Jul 4, 2023
Merged
lforst
lforst reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about

sentry/src/sentry/features/__init__.py

Line 251 in 34b3834

default_manager.add("organizations:source-maps-debug-ids", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
?

@iambriccardo
Copy link
Member Author

organizations:source-maps-debug-ids

Oh yeah, don't know why my IDE search didn't find it, thanks!

@iambriccardo iambriccardo requested a review from lforst July 4, 2023 12:42
@lforst lforst mentioned this pull request Jul 4, 2023
Closed
@iambriccardo iambriccardo merged commit b9f8b26 into master Jul 4, 2023
@iambriccardo iambriccardo deleted the riccardo/fix/remove-flag branch July 4, 2023 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lforst lforst Awaiting requested review from lforst

Assignees
No one assigned
Labels
Do Not Merge Don't merge Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iambriccardo @lforst