Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(sdk-crash-detection): Remove context detected #52108

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

philipphofmann
Copy link
Member

Remove the detected field of sdk-crash-detection context, as we can avoid an infinite processing loop by looking at the project_id and event_id instead.

Remove the detected field of sdk-crash-detection context,
as we can avoid an infinite processing loop by looking at the project_id
and event_id instead.
@philipphofmann philipphofmann added the Scope: Backend Automatically applied to PRs that change backend components label Jul 4, 2023
@philipphofmann philipphofmann requested a review from a team July 4, 2023 06:17
@philipphofmann philipphofmann enabled auto-merge (squash) July 4, 2023 06:17
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #52108 (fddb951) into master (f52e733) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #52108   +/-   ##
=======================================
  Coverage   79.31%   79.31%           
=======================================
  Files        4901     4901           
  Lines      205080   205080           
  Branches    35057    35057           
=======================================
+ Hits       162662   162666    +4     
+ Misses      37459    37454    -5     
- Partials     4959     4960    +1     
Impacted Files Coverage Δ
...rc/sentry/utils/sdk_crashes/sdk_crash_detection.py 94.87% <100.00%> (ø)

... and 4 files with indirect coverage changes

@philipphofmann philipphofmann self-assigned this Jul 4, 2023
@philipphofmann philipphofmann merged commit bd53a6c into master Jul 4, 2023
58 checks passed
@philipphofmann philipphofmann deleted the ref/sdk-crash-detection-context branch July 4, 2023 07:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants