fix(sdk-crash): Keep SDK frames based on filename #52242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a test case with an anonymized real-world Cocoa SDK crash in the thread inspector surfaced a bug in the frame stripping logic. The event stripper removed SDK frames cause it applied the allow list before stripping the frames, which removed information required to detect whether a frame is an SDK frame. This PR fixes that problem by calling the frame stripping logic before applying the allow list.
philipphofmann
added
the
Scope: Backend
iker-barriocanal
approved these changes
Jul 5, 2023
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52242 +/- ##
==========================================
- Coverage 79.31% 76.93% -2.38%
==========================================
Files 4903 4903
Lines 205319 205321 +2
Branches 35102 35102
==========================================
- Hits 162843 157959 -4884
- Misses 37502 42275 +4773
- Partials 4974 5087 +113
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test case with an anonymized real-world Cocoa SDK crash in the thread inspector surfaced a bug in the frame stripping logic. The event stripper removed SDK frames cause it applied the allow list before stripping the frames, which removed information required to detect whether a frame is an SDK frame. This PR fixes that problem by calling the frame stripping logic before applying the allow list.