Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(github-comments): remove temp have qs text #52291

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

cathteng
Copy link
Member

@cathteng cathteng commented Jul 5, 2023

To prepare for rollout we should remove the Have questions? Reach out to us in the #proj-github-pr-comments channel. from the comment text.

Manual revert of #51553

@cathteng cathteng requested review from a team and AniketDas-Tekky as code owners July 5, 2023 17:17
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #52291 (55ca328) into master (ee44c6b) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #52291   +/-   ##
=======================================
  Coverage   79.30%   79.31%           
=======================================
  Files        4904     4904           
  Lines      205491   205482    -9     
  Branches    35131    35131           
=======================================
- Hits       162974   162970    -4     
+ Misses      37538    37533    -5     
  Partials     4979     4979           
Impacted Files Coverage Δ
src/sentry/tasks/integrations/github/pr_comment.py 100.00% <ø> (ø)
...components/events/eventTagsAndScreenshot/index.tsx 82.35% <ø> (ø)
...events/eventTagsAndScreenshot/screenshot/index.tsx 72.50% <ø> (+3.45%) ⬆️
static/app/components/group/pluginActions.tsx 0.00% <ø> (ø)
...nents/replays/breadcrumbs/replayTimelineEvents.tsx 0.00% <ø> (ø)
...atic/app/components/replays/walker/splitCrumbs.tsx 100.00% <ø> (ø)
...tic/app/data/forms/organizationGeneralSettings.tsx 80.00% <ø> (ø)
static/app/utils/replays/replayDataUtils.tsx 87.09% <ø> (-2.10%) ⬇️
static/app/utils/replays/replayReader.tsx 75.00% <ø> (ø)
static/app/views/issueList/utils.tsx 90.00% <ø> (ø)
... and 1 more

... and 2 files with indirect coverage changes

@cathteng cathteng merged commit 11d1c78 into master Jul 5, 2023
55 checks passed
@cathteng cathteng deleted the cathy/github-comments/remove-temp-have-qs branch July 5, 2023 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants