-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove django.admin #52679
chore: Remove django.admin #52679
Conversation
We haven't used django-admin in a long time and it was recently disabled in self-hosted (#52329) Given that we don't use it in saas, and it is not part of any common development workflows I think it is time to not include django-admin in our installed app list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markstory Don't forget to remove this sentry/src/sentry/db/router.py Line 49 in 2349aaf
and to DROP TABLE django_admin_log;
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52679 +/- ##
==========================================
- Coverage 79.37% 79.36% -0.01%
==========================================
Files 4920 4920
Lines 206402 206397 -5
Branches 35286 35285 -1
==========================================
- Hits 163823 163817 -6
- Misses 37555 37559 +4
+ Partials 5024 5021 -3
|
@markstory These are okay?
|
@chadwhitacre I think so. The bitfield and social_auth code won't run unless it is imported, and even if that code is imported, django.contrib.admin is still installed (as it comes with django) we're just no longer including the views/urls in our django application. @dashed I'll see if I can write a migration to remove that table. I don't think we'll be able to remove the routing line until the next squash migration as the table will be in our migration history until then. |
We haven't used django-admin in a long time and it was recently disabled in self-hosted (#52329)
Given that we don't use it in saas, and it is not part of any common development workflows I think it is time to not include django-admin in our installed app list.