Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: upgrade django to 3.2 #52713

Merged
merged 1 commit into from
Jul 13, 2023
Merged

ref: upgrade django to 3.2 #52713

merged 1 commit into from
Jul 13, 2023

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Jul 12, 2023 •
edited
Loading

same as #52269 -- but I ran out of time to deploy it

@asottile-sentry asottile-sentry requested review from a team as code owners July 12, 2023 13:49
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 12, 2023
@asottile-sentry asottile-sentry requested a review from a team July 12, 2023 13:50
@codecov
Copy link

codecov bot commented Jul 12, 2023 •
edited
Loading

Codecov Report

Merging #52713 (3e43f9b) into master (9a020f6) will increase coverage by 17.16%.
The diff coverage is 100.00%.

❗ Current head 3e43f9b differs from pull request most recent head b9dad36. Consider uploading reports for the commit b9dad36 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #52713       +/-   ##
===========================================
+ Coverage   62.20%   79.36%   +17.16%     
===========================================
  Files        4888     4922       +34     
  Lines      206133   206516      +383     
  Branches    35255    35299       +44     
===========================================
+ Hits       128216   163899    +35683     
+ Misses      73687    37593    -36094     
- Partials     4230     5024      +794
Impacted Files Coverage Δ
src/sentry/new_migrations/monkey/__init__.py 77.77% <100.00%> (ø)
...entry/silo/patches/silo_aware_transaction_patch.py 83.33% <100.00%> (-0.99%) ⬇️
src/sentry/utils/email/signer.py 89.47% <100.00%> (+39.47%) ⬆️

... and 1522 files with indirect coverage changes

@asottile-sentry asottile-sentry merged commit 25c3897 into master Jul 13, 2023
@asottile-sentry asottile-sentry deleted the asottile-upgrade-django branch July 13, 2023 13:12
michellewzhang pushed a commit that referenced this pull request Jul 13, 2023
@asottile-sentry
ref: upgrade django to 3.2 (#52713)
29817e3 
same as #52269 -- but I ran out of time to deploy it
mifu67 pushed a commit that referenced this pull request Jul 13, 2023
@asottile-sentry @mifu67
ref: upgrade django to 3.2 (#52713)
0478b18 
same as #52269 -- but I ran out of time to deploy it
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattgauntseo-sentry mattgauntseo-sentry mattgauntseo-sentry approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asottile-sentry @mattgauntseo-sentry