Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hybridcloud) Fix typing & loop error in silo router #52753

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix(hybridcloud) Fix typing & loop error in silo router #52753

merged 1 commit into from
Jul 12, 2023

Conversation

markstory
Copy link
Member

Fix a typing issue and condition within a loop that should be outside of the loop.

@markstory
fix(hybridcloud) Fix typing & loop error in silo router
594d869 
Fix a typing issue and condition within a loop that should be outside of
the loop.
@markstory markstory requested review from asottile-sentry and a team July 12, 2023 20:16
@markstory markstory added the Trigger: Silo db Trigger tests with split databases that simulate hybrid cloud data separation in postgres label Jul 12, 2023
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 12, 2023
asottile-sentry
asottile-sentry approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Jul 12, 2023 •
edited
Loading

Codecov Report

Merging #52753 (594d869) into master (2c87024) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #52753      +/-   ##
==========================================
- Coverage   79.37%   79.37%   -0.01%     
==========================================
  Files        4921     4921              
  Lines      206554   206555       +1     
  Branches    35302    35302              
==========================================
- Hits       163956   163955       -1     
- Misses      37574    37575       +1     
- Partials     5024     5025       +1
Impacted Files Coverage Δ
src/sentry/db/router.py 73.25% <60.00%> (+1.49%) ⬆️

... and 2 files with indirect coverage changes

@markstory markstory merged commit 9a020f6 into master Jul 12, 2023
@markstory markstory deleted the router-types branch July 12, 2023 21:56
michellewzhang pushed a commit that referenced this pull request Jul 13, 2023
@markstory
fix(hybridcloud) Fix typing & loop error in silo router (#52753)
58f9ba5 
Fix a typing issue and condition within a loop that should be outside of
the loop.
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asottile-sentry asottile-sentry asottile-sentry approved these changes

@vbro vbro vbro approved these changes

@dashed dashed dashed approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Silo db Trigger tests with split databases that simulate hybrid cloud data separation in postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markstory @dashed @vbro @asottile-sentry