Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk-crashes): Info on custom stacktrace rule #52781

Merged
merged 1 commit into from
Jul 13, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sentry/utils/sdk_crashes/event_stripper.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,9 @@ def _strip_frames(
"""

def strip_frame(frame: MutableMapping[str, Any]) -> MutableMapping[str, Any]:
# Set in_app to True for SDK frames for grouping. Anyways the grouping config will set in_app false
# for all Cocoa SDK frames. To not change the grouping logic, we must add the following stacktrace
# rule `stack.abs_path:Sentry.framework +app` to the project with the ID SDK_CRASH_DETECTION_PROJECT_ID.
if sdk_crash_detector.is_sdk_frame(frame):
frame["in_app"] = True

Expand Down
Loading