Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React UI login routes #52885

Closed
wants to merge 4 commits into from
Closed

Conversation

nhsiehgit
Copy link
Contributor

POC

enable react login page views
point login page to existing login api

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jul 14, 2023
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #52885 (b51ec20) into feature_auth_in (942e278) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@               Coverage Diff                @@
##           feature_auth_in   #52885   +/-   ##
================================================
  Coverage            79.38%   79.39%           
================================================
  Files                 4935     4935           
  Lines               207373   207376    +3     
  Branches             35436    35436           
================================================
+ Hits                164633   164641    +8     
+ Misses               37704    37700    -4     
+ Partials              5036     5035    -1     
Impacted Files Coverage Δ
src/sentry/api/urls.py 100.00% <ø> (ø)
src/sentry/auth/helper.py 90.86% <ø> (ø)
src/sentry/web/urls.py 92.30% <ø> (ø)
static/app/views/auth/login.tsx 94.59% <ø> (ø)
static/app/views/auth/loginForm.tsx 100.00% <ø> (ø)
static/app/views/dashboards/controls.tsx 94.28% <ø> (ø)
src/sentry/api/endpoints/auth_login.py 100.00% <100.00%> (ø)
src/sentry/web/frontend/auth_login.py 83.07% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented Oct 19, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 19, 2023
@getsantry getsantry bot closed this Oct 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant