Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack trace linking for Bitbucket #52952

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Stack trace linking for Bitbucket #52952

merged 4 commits into from
Sep 28, 2023

Conversation

jianyuan
Copy link
Contributor

@jianyuan jianyuan commented Jul 16, 2023

This PR enables Stack trace linking for Bitbucket.

Depends on #53584

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #52952 (78f58a8) into master (24148fc) will increase coverage by 1.72%.
Report is 8 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 78f58a8 differs from pull request most recent head 1f9e76b. Consider uploading reports for the commit 1f9e76b to get more accurate results

@@            Coverage Diff             @@
##           master   #52952      +/-   ##
==========================================
+ Coverage   78.23%   79.95%   +1.72%     
==========================================
  Files        5085     5034      -51     
  Lines      219413   214531    -4882     
  Branches    37158    36439     -719     
==========================================
- Hits       171654   171526     -128     
+ Misses      42076    37736    -4340     
+ Partials     5683     5269     -414     
Files Changed Coverage
src/sentry/integrations/bitbucket/client.py 100.00%
src/sentry/integrations/bitbucket/integration.py 100.00%

@vercel
Copy link

vercel bot commented Aug 25, 2023

@leedongwei is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@leeandher leeandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Same comment I had for the VSTS integration, but we'll need to make sure the payload shows up on the project_stacktrace_link endpoint so that we can render these on the frontend. Can we test that this happens or add it if needed?

@vercel
Copy link

vercel bot commented Sep 22, 2023

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@jianyuan jianyuan marked this pull request as ready for review September 22, 2023 08:50
@jianyuan jianyuan requested a review from a team as a code owner September 22, 2023 08:50
@leeandher leeandher added the Trigger: getsentry tests once code is reviewed: apply label to PR to trigger getsentry tests label Sep 28, 2023
@leeandher
Copy link
Member

/gcbrun

@leeandher leeandher merged commit a13a813 into getsentry:master Sep 28, 2023
49 of 51 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: getsentry tests once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants