Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alerts): on demand metric alert chart #52962

Merged
merged 5 commits into from
Jul 21, 2023
Merged

feat(alerts): on demand metric alert chart #52962

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f167c5f
feat(alerts): on demand metric alert chart
obostjancic Jul 17, 2023
17d68f7
Merge branch 'master' into ogi/feat/on-demand-alerts-chart-fe
obostjancic Jul 17, 2023
213c10c
pass useOnDemandMetricsFlag
obostjancic Jul 20, 2023
ddf4a31
test fix
obostjancic Jul 20, 2023
c288b63
Merge branch 'master' into ogi/feat/on-demand-alerts-chart-fe
obostjancic Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions static/app/views/alerts/rules/metric/details/metricChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ import {
MetricRule,
TimePeriod,
} from 'sentry/views/alerts/rules/metric/types';
import {isOnDemandMetricAlert} from 'sentry/views/alerts/rules/metric/utils/onDemandMetricAlert';
import {getChangeStatus} from 'sentry/views/alerts/utils/getChangeStatus';
import {AlertWizardAlertNames} from 'sentry/views/alerts/wizard/options';
import {getAlertTypeFromAggregateDataset} from 'sentry/views/alerts/wizard/utils';
Expand Down Expand Up @@ -503,14 +502,6 @@ class MetricChart extends PureComponent<Props, State> {
newAlertOrQuery: false,
});

if (isOnDemandMetricAlert(rule.dataset, rule.query)) {
return this.renderEmpty(
t(
'This alert includes advanced conditions, which is a feature that is currently in early access. Charts are not yet supported at this time.'
)
);
}

return isCrashFreeAlert(dataset) ? (
<SessionsRequest
api={api}
Expand Down