-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(hybrid-cloud): Removes transaction silo routing from patch code #53080
ref(hybrid-cloud): Removes transaction silo routing from patch code #53080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Do we have any transaction.atomic() calls to update in getsentry? |
I believe @corps already patched most, if not all of them. Guess we'll find out 😁 |
afcb441
to
f50e9b6
Compare
f50e9b6
to
1e626c3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53080 +/- ##
=======================================
Coverage 79.49% 79.49%
=======================================
Files 4935 4935
Lines 207734 207737 +3
Branches 35452 35454 +2
=======================================
+ Hits 165141 165149 +8
+ Misses 37563 37558 -5
Partials 5030 5030
|
f84393b
to
9fa35f5
Compare
…organization user query to use this now
9fa35f5
to
c938090
Compare
PR reverted: 4705814 |
reverting, got a failure in getsentry:
|
…using unguarded_write decorators (#53160) With the inclusion of our recent changes to transaction validations in PR #52943 and the inclusion of 'using' in all of our transactions/helpers thanks to PRs #53027 and #53004, we should be able to safely remove the ability to specify a transaction without a using keyword arg. Because this is now mandatory, it should also be safe to remove autorouting, which ended up being incorrect in many testing contexts anyway. This is a resubmission of PR #53080 which was reverted due to broken load-mocks and a single broken getsentry migration test.
With the inclusion of our recent changes to transaction validations in PR #52943 and the inclusion of 'using' in all of our transactions/helpers thanks to PRs #53027 and #53004, we should be able to safely remove the ability to specify a transaction without a
using
keyword arg.Because this is now mandatory, it should also be safe to remove autorouting, which ended up being incorrect in many testing contexts anyway.