Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit(api): Remove org roles from API responses b/c not public #53106

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

schew2381
Copy link
Contributor

No description provided.

@schew2381 schew2381 requested a review from a team July 18, 2023 20:08
@schew2381 schew2381 self-assigned this Jul 18, 2023
@schew2381 schew2381 requested a review from a team as a code owner July 18, 2023 20:08
@schew2381 schew2381 changed the title nit(api): Remove org roles from api responses b/c not public yet nit(api): Remove org roles from api doc responses b/c not public yet Jul 18, 2023
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 18, 2023
@schew2381 schew2381 changed the title nit(api): Remove org roles from api doc responses b/c not public yet nit(api): Remove org roles from API doc responses b/c not public Jul 18, 2023
Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah this is from my stuff. ty!

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #53106 (18f4ead) into master (92a6928) will decrease coverage by 1.70%.
Report is 389 commits behind head on master.
The diff coverage is 93.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #53106      +/-   ##
==========================================
- Coverage   79.48%   77.79%   -1.70%     
==========================================
  Files        4935     4940       +5     
  Lines      207690   209173    +1483     
  Branches    35456    35639     +183     
==========================================
- Hits       165086   162716    -2370     
- Misses      37570    41368    +3798     
- Partials     5034     5089      +55     
Files Changed Coverage Δ
...pi/endpoints/team_notification_settings_details.py 100.00% <ø> (ø)
...pi/endpoints/user_notification_settings_details.py 100.00% <ø> (ø)
src/sentry/apidocs/examples/team_examples.py 100.00% <ø> (ø)
...atic/app/components/assistant/getGuidesContent.tsx 33.33% <ø> (ø)
...try/api/serializers/models/notification_setting.py 94.11% <92.30%> (+9.67%) ⬆️
src/sentry/api/serializers/models/team.py 94.00% <100.00%> (+0.06%) ⬆️

... and 446 files with indirect coverage changes

@schew2381 schew2381 changed the title nit(api): Remove org roles from API doc responses b/c not public nit(api): Remove org roles from API responses b/c not public Jul 19, 2023
@schew2381 schew2381 added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 24, 2023
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@schew2381 schew2381 merged commit 2f3a36d into master Jul 25, 2023
54 of 55 checks passed
@schew2381 schew2381 deleted the seiji/nit/remove-org-role-from-api-examples branch July 25, 2023 23:46
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants