Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dnd-worldmap-removal) Removed worldmap display option from discover chart. #53185

Merged
merged 2 commits into from
Jul 25, 2023
Merged

feat(dnd-worldmap-removal) Removed worldmap display option from discover chart. #53185

merged 2 commits into from
Jul 25, 2023

Conversation

Abdkhan14
Copy link
Contributor

@Abdkhan14 Abdkhan14 commented Jul 19, 2023 •
edited
Loading

For issue: #51315
Steps outlined: here.

  • Won't be merging until, data-migration PR for converting world map widgets to table widgets is deployed.
  • Removes the World map display mode from discover chart footer:
Screenshot 2023-07-19 at 3 59 54 PM
  • Should not effect the loading of existing discover saved queries, homepages and previews with world map display mode:
    • Falls back to AreaChart instead of WorldMapChart: code
    • Falls back to Total Period display mode instead: code
  • Removed tests and blocks of code using: DisplayMode.WORLDMAP.
  • Added unused components like WorldMapChart and EventsGeoRequest to clean up list for removal.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 19, 2023
@Abdkhan14 Abdkhan14 requested review from a team and wmak July 19, 2023 20:07
@Abdkhan14 Abdkhan14 mentioned this pull request Jul 20, 2023
Merged
@Abdkhan14 Abdkhan14 marked this pull request as ready for review July 20, 2023 18:27
@Abdkhan14 Abdkhan14 requested a review from a team as a code owner July 20, 2023 18:27
@Abdkhan14 Abdkhan14 requested a review from a team July 20, 2023 18:27
mjq-sentry
mjq-sentry approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@mjq-sentry mjq-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@Abdkhan14 Abdkhan14 merged commit a09c35d into master Jul 25, 2023
@Abdkhan14 Abdkhan14 deleted the abdkhan/discover-worldmap-display-option branch July 25, 2023 18:03
Abdkhan14 added a commit that referenced this pull request Jul 25, 2023
@Abdkhan14
feat(discover-saved-query-worldmap) Added migration to convert worldm…
43ea505 
…ap to total period display (#53276)

For issue: #51315
Steps outlined:
[here](https://www.notion.so/sentry/Removing-World-Map-display-from-Discover-and-Dashboards-e49eb198fe294ad0a1b4c47b9c3619c0?pvs=4#43e2c318d1eb4f93987718b82307f56f).

- Won't be merging until, frontend
[PR](#53185) removing worldmap
display option from discover is deployed. Therefore, there won't be a
time gap.
- There are only 28 discover saved queries using the worldmap display:
[query](https://redash.getsentry.net/queries/4484)
- Migration converts worldmap display mode marked by `'display':
'worldmap'` in the query field of the `DiscoverSavedQuery` model to
`'display':'default'` which represents the total period display mode.

---------

Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjq-sentry mjq-sentry mjq-sentry approved these changes

@wmak wmak Awaiting requested review from wmak

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abdkhan14 @mjq-sentry