Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(profiling): Deobfuscate Android methods' signature #53427

Merged
merged 13 commits into from
Jul 25, 2023
Merged

feat(profiling): Deobfuscate Android methods' signature #53427

merged 13 commits into from
Jul 25, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Jul 24, 2023

No description provided.

@phacops phacops requested a review from a team as a code owner July 24, 2023 13:29
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Merging #53427 (54ff842) into master (9526d5e) will decrease coverage by 3.24%.
The diff coverage is 77.92%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #53427      +/-   ##
==========================================
- Coverage   79.54%   76.31%   -3.24%     
==========================================
  Files        4942     4916      -26     
  Lines      208640   208839     +199     
  Branches    35546    35583      +37     
==========================================
- Hits       165973   159385    -6588     
- Misses      37606    44265    +6659     
- Partials     5061     5189     +128
Files Changed Coverage Δ
src/sentry/profiles/task.py 42.89% <68.75%> (+0.21%) ⬆️
src/sentry/profiles/java.py 80.32% <80.32%> (ø)

... and 539 files with indirect coverage changes

@phacops phacops mentioned this pull request Jul 24, 2023
Merged
@phacops phacops requested a review from Zylphrex July 25, 2023 12:49
Zylphrex
Zylphrex reviewed Jul 25, 2023
View reviewed changes
src/sentry/profiles/java.py Outdated Show resolved Hide resolved
src/sentry/profiles/java.py Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
src/sentry/profiles/task.py Show resolved Hide resolved
src/sentry/profiles/task.py Outdated Show resolved Hide resolved
@phacops phacops requested a review from Zylphrex July 25, 2023 14:42
@phacops phacops enabled auto-merge (squash) July 25, 2023 15:15
@phacops phacops merged commit 6584123 into master Jul 25, 2023
55 checks passed
@phacops phacops deleted the pierre/profiling-deobfuscate-signature branch July 25, 2023 15:26
@phacops phacops added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jul 25, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: af3ae3b

getsentry-bot added a commit that referenced this pull request Jul 25, 2023
@getsentry-bot @phacops
Revert "feat(profiling): Deobfuscate Android methods' signature (#53427…
af3ae3b 
…)"

This reverts commit 6584123.

Co-authored-by: phacops <336345+phacops@users.noreply.github.com>
chloeho7 pushed a commit that referenced this pull request Jul 25, 2023
@phacops @chloeho7
feat(profiling): Deobfuscate Android methods' signature (#53427)
126f80b
chloeho7 pushed a commit that referenced this pull request Jul 25, 2023
@getsentry-bot @phacops @chloeho7
Revert "feat(profiling): Deobfuscate Android methods' signature (#53427…
58ae896 
…)"

This reverts commit 6584123.

Co-authored-by: phacops <336345+phacops@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phacops @getsentry-bot @Zylphrex