feat(alerts): use extrapolated data during creation #53428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Frontend
obostjancic
removed
the
Scope: Backend
obostjancic
force-pushed
the
ogi/feat/on-demand-alerts-chart-extrapolation
branch
from
5d8d338
to
1e6981f
Compare
Co-authored-by: Priscila Oliveira <priscila.oliveira@sentry.io>
Co-authored-by: Priscila Oliveira <priscila.oliveira@sentry.io>
|
shall we create unit/integration tests for this change? |
priscilawebdev
approved these changes
Jul 31, 2023
| </OnDemandMetricRequest> | ||
| ); | ||
|
|
||
| expect(doEventsRequest).toHaveBeenCalledWith( |
There was a problem hiding this comment.
done we need to check for the number of calls here too? expect(doEventsRequest).toHaveBeenCalledTimes(2);
There was a problem hiding this comment.
Yep, we can, added in d36fc34
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: Support chart queries for on-demand metrics#52508
Adds A separate request flow for on-deamnd metric alerts that queries
event-statsto check if the on-demand metric matching filters is already present. If it is displays that Timeseries data. If not it repeats the request toevent-statsfalling back to indexed data, and extrapolates it using the dynamic sampling rate.